[SandboxTest] Improve input validation and WSB file generation#388302
Merged
Madhusudhan-MSFT merged 1 commit intoJun 16, 2026
Conversation
## Summary
Strengthen SandboxTest.ps1 parameter handling and WSB configuration
output to ensure robust behavior with diverse input paths and options.
## Changes
- **MapFolder validation**: Reject folder paths containing characters that
are problematic for XML embedding (', ", <, >, &) with a clear
error message identifying the forbidden characters
- **WinGetOptions validation**: Add a dynamic allow-list that parses valid
flags directly from winget install --help at runtime, ensuring the
validation stays current with any installed WinGet version. Includes
Write-Debug tracing for observability. Gracefully skips validation
with a warning when WinGet is not installed on the host
- **WSB XML generation**: Apply [System.Security.SecurityElement]::Escape()
to all four interpolated paths (TestDataFolder, PrimaryMappedFolder,
SandboxWorkingDirectory, SandboxBootstrapFile) before emitting into
the .wsb configuration file, producing well-formed XML regardless
of path content
## Impact
- Paths containing XML-meaningful characters no longer produce malformed
.wsb files that fail to launch
- Invalid or unrecognized flags passed via -WinGetOptions are caught
early with an actionable error message listing all accepted flags
- No behavioral change for typical usage — standard paths and valid
WinGet flags work exactly as before
microsoft-github-policy-service
Bot
added
the
Needs-Attention
Trenly
approved these changes
Jun 16, 2026
microsoft-github-policy-service
Bot
added
the
Moderator-Approved
denelon
approved these changes
Jun 16, 2026
microsoft-github-policy-service
Bot
removed
the
Needs-Attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthen SandboxTest.ps1 parameter handling and WSB configuration output to ensure robust behavior with diverse input paths and options.
Changes
',",<,>,&) with a clear error message identifying the forbidden characterswinget install --helpat runtime, ensuring the validation stays current with any installed WinGet version. IncludesWrite-Debugtracing for observability. Gracefully skips validation with a warning when WinGet is not installed on the host[System.Security.SecurityElement]::Escape()to all four interpolated paths (TestDataFolder, PrimaryMappedFolder, SandboxWorkingDirectory, SandboxBootstrapFile) before emitting into the.wsbconfiguration file, producing well-formed XML regardless of path contentImpact
.wsbfiles that fail to launch-WinGetOptionsare caught early with an actionable error message listing all accepted flagsMicrosoft Reviewers: Open in CodeFlow