Manual Validation: 6/12 Enum update#387274
Closed
stephengillie wants to merge 1 commit into
Closed
Conversation
Added JSON file, containing enumeration data. Along with extensive fixes and updates.
microsoft-github-policy-service
Bot
added
the
Needs-Attention
microsoft-github-policy-service
Bot
removed
the
Needs-Attention
| Process process = new Process(); | ||
| StreamWriter StandardInput; | ||
| StreamReader StandardOut; | ||
| ProcessStartInfo processStartInfo = new ProcessStartInfo("PowerShell.exe"); |
Contributor
There was a problem hiding this comment.
This also should be winget.exe
| Where-Object {`$_ -notmatch 'Microsoft.Windows.Search'} | | ||
| Where-Object {`$_ -notmatch 'Microsoft\\Edge\\Application'} | | ||
| Where-Object {`$_ -notmatch 'msedge'} | | ||
| Where-Object {`$_ -notmatch |
Contributor
There was a problem hiding this comment.
Please validate YamlValue results against the manifest schema before using them here, and fail fast on any mismatch. Since this pattern appears in multiple places, it would be better to enforce this centrally anywhere YamlValue is read rather than fixing individual call sites.
Collaborator
Author
There was a problem hiding this comment.
This is a removal section. These lines don't seem to exist in my current version. From the lines, this appars to be the sub-script that is written to disk and run by the VM, so there aren't any YAML values here to validate.
I'll see if I can do this in other sections, where valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Added JSON file, containing enumeration data. Along with extensive fixes and updates.
✅ Checklist
📦 Manifest Checklist
winget validate --manifest <path>(validation guide)winget install --manifest <path>Microsoft Reviewers: Open in CodeFlow