Skip to content

Upgrade D3D12 Agility SDK to 1.619.3#2263

Merged
jevansaks merged 1 commit into
microsoft:mainfrom
Traverse-Research:agility-1.619
May 29, 2026
Merged

Upgrade D3D12 Agility SDK to 1.619.3#2263
jevansaks merged 1 commit into
microsoft:mainfrom
Traverse-Research:agility-1.619

Conversation

@MarijnS95
Copy link
Copy Markdown
Contributor

@MarijnS95 MarijnS95 commented May 27, 2026

@MarijnS95 MarijnS95 requested review from a team, jevansaks and vineeththomasalex as code owners May 27, 2026 12:23
@jevansaks
Copy link
Copy Markdown
Member

@MarijnS95 looks like the compare to last release failed

CompareBinToLastRelease.ps1: D:\a\win32metadata\win32metadata\scripts\TestWinmdBinary.ps1:24

@MarijnS95
Copy link
Copy Markdown
Contributor Author

MarijnS95 commented May 28, 2026

@jevansaks that is an expected transitive failure because the package is not allowed to be downloaded via the custom nuget registry. Unfortunately the build continues despite failing restore, ultimately reaching an error in that test script when trying to read the path for the package which doesn't exist.

https://github.com/microsoft/win32metadata/actions/runs/26510889237/job/78153858551?pr=2263 has:

Restoring buildtools project...
  Determining projects to restore...
  Failed to download package 'Microsoft.Direct3D.D3D12.1.619.3' from 'https://pkgs.dev.azure.com/shine-oss/31aa4786-aa65-4b5d-b1fc-e3443e50b84e/_packaging/5a2a6e64-68a6-4cf7-8465-2b2817cb8301/nuget/v3/flat2/microsoft.direct3d.d3d12/1.619.3/microsoft.direct3d.d3d12.1.619.3.nupkg'.
...
C:\Program Files\dotnet\sdk\8.0.421\NuGet.targets(174,5): error : Failed to download package 'Microsoft.Direct3D.D3D12.1.619.3' from 'https://pkgs.dev.azure.com/shine-oss/31aa4786-aa65-4b5d-b1fc-e3443e50b84e/_packaging/5a2a6e64-68a6-4cf7-8465-2b2817cb8301/nuget/v3/flat2/microsoft.direct3d.d3d12/1.619.3/microsoft.direct3d.d3d12.1.619.3.nupkg'. [D:\a\win32metadata\win32metadata\buildtools\BuildTools.proj]
C:\Program Files\dotnet\sdk\8.0.421\NuGet.targets(174,5): error : Response status code does not indicate success: 401 (Unauthorized - No local versions of package 'microsoft.direct3d.d3d12'; please provide authentication to access versions from upstream that have not yet been saved to your feed. (DevOps Activity ID: B0002C09-DEFC-4F01-89CD-6E077E291365)). [D:\a\win32metadata\win32metadata\buildtools\BuildTools.proj]
C:\Program Files\dotnet\sdk\8.0.421\NuGet.targets(174,5): error : The feed 'Win32Metadata-Dependencies [https://pkgs.dev.azure.com/shine-oss/Win32Metadata/_packaging/Win32Metadata-Dependencies/nuget/v3/index.json]' lists package 'Microsoft.Direct3D.D3D12.1.619.3' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [D:\a\win32metadata\win32metadata\buildtools\BuildTools.proj]
  Failed to restore D:\a\win32metadata\win32metadata\buildtools\BuildTools.proj (in 6.73 sec).
  6 of 7 projects are up-to-date for restore.
...

*** Comparing .winmd to last release
Getting NuGet Props for property PkgMicrosoft_Windows_SDK_Win32Metadata from BuildTools.proj
CompareBinToLastRelease.ps1: D:\a\win32metadata\win32metadata\scripts\TestWinmdBinary.ps1:24
Line |
  24 |  & "$PSScriptRoot\CompareBinToLastRelease.ps1" -SkipInstallTools
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot bind argument to parameter 'Path' because it is null.

(There are no detailed line-based logs for the invocation of CompareBinToLastRelease.ps1 unfortunately, pointing to the exact line where this is problematic)

@jevansaks
Copy link
Copy Markdown
Member

Ah, I misread. Thanks for that. I pulled the latest version through the feed and am re-trying the failed job.

@jevansaks jevansaks enabled auto-merge (squash) May 28, 2026 14:17
@jevansaks
Copy link
Copy Markdown
Member

@MarijnS95 please re-base the branch so I can approve it? (I could click the button but then I can no longer be the approver)

auto-merge was automatically disabled May 29, 2026 08:55

Head branch was pushed to by a user without write access

@MarijnS95
Copy link
Copy Markdown
Contributor Author

Oh, this repo requires every PR to be on top of main for endless rebasing...

@jevansaks jevansaks enabled auto-merge (squash) May 29, 2026 17:48
@jevansaks
Copy link
Copy Markdown
Member

Oh, this repo requires every PR to be on top of main for endless rebasing...

This is necessary until we have a better process for changessincelastrelease.txt. My thinking on that is that instead of having one giant file that everyone contributes to that is guaranteed to conflict, we have a delta file that is named differently per PR. Once we have that then we can avoid the need to be up-to-date. If you want to take a crack at that, I'd welcome the contribution. Otherwise I'll send a robot after it ... eventually. ;)

@jevansaks jevansaks merged commit a3c6e3f into microsoft:main May 29, 2026
5 of 9 checks passed
@MarijnS95 MarijnS95 deleted the agility-1.619 branch May 29, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants