Skip to content

Make Rolling Window work on CPUs#9

Draft
clairecporter wants to merge 6 commits into
microsoft:mainfrom
clairecporter:rw-cpu
Draft

Make Rolling Window work on CPUs#9
clairecporter wants to merge 6 commits into
microsoft:mainfrom
clairecporter:rw-cpu

Conversation

@clairecporter
Copy link
Copy Markdown

Also

  1. Add a minimum standard deviation to the rolling window calculations
  2. Fix up the edge slicing logic when putting patches back together

Comment thread whales/methods.py
x + half_kernel : x + patch_size - half_kernel,
] = p_output[:, half_kernel:-half_kernel, half_kernel:-half_kernel]
# Edge-slicing logic
y1_in, y2_in = y, min(y + patch_size, height)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this is much better!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take no credit. Gemini did the work on that one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants