Skip to content

fix(smoke): type mocha context for dispose hooks #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EmmaYuan1015 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Draft

fix(smoke): type mocha context for dispose hooks #2667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/smoke/suites/actionBar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function startActionBarTests(): void {
return app.getMainPage();
}

async function dispose() {
async function dispose(this: Mocha.Context): Promise<void> {
if (this.currentTest?.state === "failed") {
SmokeTestLogger.info("Test failed, taking screenshot ...");
await screenshots.takeScreenshots(
Expand Down
4 changes: 2 additions & 2 deletions test/smoke/suites/helper/baseSmokeTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class BaseSmokeTest {
* Common dispose function to be called after each test
* Takes screenshots on failure and closes the app
*/
public static async dispose(this: any): Promise<void> {
public static async dispose(this: Mocha.Context): Promise<void> {
if (this.currentTest?.state === "failed") {
SmokeTestLogger.info("Test failed, taking screenshot ...");
await screenshots.takeScreenshots(
Expand All @@ -30,7 +30,7 @@ export class BaseSmokeTest {
);
}
try {
SmokeTestLogger.info(`Dispose test: "${this.currentTest.title}" ...`);
SmokeTestLogger.info(`Dispose test: "${this.currentTest?.title ?? "unknown"}" ...`);
if (app) {
await app.close();
}
Expand Down