fix: resolve #174 - fix regex for hyphenated tag names in HTML scanner#241
Open
maruthang wants to merge 1 commit into
Open
fix: resolve #174 - fix regex for hyphenated tag names in HTML scanner#241maruthang wants to merge 1 commit into
maruthang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #174
Bug: Hyphenated custom element tag names (e.g.,
<s-c-feature>) were not scanned correctly, causing Vue HTML scan errors.Root Cause: In
nextElementName()inhtmlScanner.ts, the regex character class[_:\w-.\d]placed the hyphen between\wand., making it ambiguous (interpreted as a range rather than a literal hyphen).Fix: Moved the hyphen to the end of the character class (
[_:\w.\d-]) so it is unambiguously treated as a literal hyphen character.Changes
src/parser/htmlScanner.ts: Fixed regex innextElementName()— moved hyphen to end of character classsrc/test/scanner.test.ts: Added 3 regression tests for hyphenated tag names (Vue custom element, self-closing, and with attributes)Testing
src/test/scanner.test.tsthat verify correct tokenization of hyphenated element names likes-c-feature,my-component, andel-button