Skip to content

docs: improve tree shaking docs#4155

Open
vivekjm wants to merge 2 commits into
microsoft:mainfrom
vivekjm:docs-tree-shaking-guide
Open

docs: improve tree shaking docs#4155
vivekjm wants to merge 2 commits into
microsoft:mainfrom
vivekjm:docs-tree-shaking-guide

Conversation

@vivekjm
Copy link
Copy Markdown

@vivekjm vivekjm commented May 17, 2026

Summary

  • point the bundling guide at the existing @rnx-kit/metro-serializer-esbuild documentation instead of adding a separate tree-shaking guide
  • expand the serializer README with @rnx-kit/cli / rnx-bundle tree-shaking setup, serializer options, production-only behavior, and analyzer guidance

Fixes #1280

Test plan

  • git diff --check
  • yarn build in docsite generated static files successfully and reported existing /rnx-kit/docs/community HTML minifier warnings; the process did not return after success and was terminated manually

Comment thread docsite/docs/guides/bundling.mdx Outdated
@vivekjm vivekjm force-pushed the docs-tree-shaking-guide branch from a6504aa to 3f79e12 Compare May 19, 2026 09:02
@vivekjm vivekjm changed the title docs: add tree shaking guide docs: improve tree shaking docs May 19, 2026
Copy link
Copy Markdown
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've left some minor comments

Comment thread packages/metro-serializer-esbuild/README.md Outdated
Comment thread packages/metro-serializer-esbuild/README.md Outdated
Comment thread packages/metro-serializer-esbuild/README.md
@vivekjm vivekjm force-pushed the docs-tree-shaking-guide branch from 3f79e12 to e0d6e49 Compare May 22, 2026 10:04
Copy link
Copy Markdown
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again ❤️

@tido64
Copy link
Copy Markdown
Member

tido64 commented May 22, 2026

Looks like build failed because of a missing change log entry. Can you run yarn change --empty locally and push the commit?

@vivekjm
Copy link
Copy Markdown
Author

vivekjm commented May 22, 2026

Done, thanks. I ran yarn change --empty, pushed the empty changeset commit, and verified it locally with yarn change:check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

how-to guide for tree-shaking

2 participants