fix(windows): simplify app initialization with ReactNativeWin32App#2780
Open
tido64 wants to merge 1 commit into
Open
fix(windows): simplify app initialization with ReactNativeWin32App#2780tido64 wants to merge 1 commit into
ReactNativeWin32App#2780tido64 wants to merge 1 commit into
Conversation
tido64
force-pushed
the
tido/windows/use-app-builder
branch
6 times, most recently
from
23363d2 to
3437dfa
Compare
tido64
force-pushed
the
tido/windows/use-app-builder
branch
from
3437dfa to
1e98046
Compare
acoates-ms
reviewed
May 21, 2026
| switch (source) { | ||
| case JSBundleSource::DevServer: | ||
| instanceSettings.JavaScriptBundleFile(L"index"); | ||
| instanceSettings.DebugBundlePath(L"index"); |
Contributor
There was a problem hiding this comment.
You should just set DebugBundlePath and JavaScriptBundleFile always. The only think you need to change for lading from DevServer vs Embedded is UseFastRefresh.
Member
Author
There was a problem hiding this comment.
Isn't that wrong? UseFastRefresh can be disabled in dev mode if you wish to manually reload. Using it to determine whether to use the embedded JS bundle seems wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify app initialization with
ReactNativeWin32AppPlatforms affected
Test plan
Screenshots