fix(0.81, podspec): comment out duplicate scrollview subspec in React-FabricComponents#2970
Draft
Saadnajmi wants to merge 1 commit into
Draft
Conversation
…cComponents
# [macOS
The `scrollview` subspec is declared in BOTH `React-Fabric.podspec` and
`React-FabricComponents.podspec`, with overlapping `source_files`:
React-Fabric.podspec:
react/renderer/components/scrollview/**/*.{m,mm,cpp,h} (recursive)
React-FabricComponents.podspec:
react/renderer/components/scrollview/*.{m,mm,cpp,h}
react/renderer/components/scrollview/platform/cxx/**/*
Both globs include the same top-level files (ScrollViewShadowNode.cpp,
BaseScrollViewProps.cpp, ScrollEvent.cpp, etc.). After `pod install`,
those source files end up in both the React-Fabric and React-FabricComponents
Pods targets.
What breaks:
- Consumers that link both libraries (e.g. via `-all_load`) hit
duplicate symbol errors at link time.
- Consumers that deduplicate by hand by dropping scrollview from one
target break differently: React-Fabric's
mounting/internal/CullingContext.cpp references ScrollViewShadowNode,
so if the dedup drops it from React-Fabric, link fails with
`Undefined symbols: ScrollViewShadowNode`.
Comment out (rather than delete) the duplicate scrollview subspec in
React-FabricComponents, using the macOS diff-tag convention. The
recursive glob in React-Fabric.podspec's scrollview subspec already
covers everything FabricComponents was listing
(top-level files + scrollview/platform/cxx/**/*).
# macOS]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of the changes from branch
fix/remove-duplicate-scrollview-subspecto0.81-stable.Original PR: #2969
Test Plan
Same as the original PR — verified locally via
pod installinpackages/rn-tester/that:React-Fabric-macOStarget's Sources phase containsScrollViewShadowNode.cpp(and the other scrollview sources).React-FabricComponents-macOStarget's Sources phase does NOT contain those files.