homescreen style and keyboard nav fixes#11311
Open
jwunderl wants to merge 5 commits into
Open
Conversation
…he source card the detail view came from instead of further down page
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes several home screen styling and keyboard navigation issues in the projects view, primarily around the detail view interaction and focus management.
Changes:
- Restores selected card visual styling (border + arrow indicator) and applies focus-visible styling to the search/go-back buttons.
- Moves the detail view's CloseButton to the end of the detail container (so tab order is sensible) and restores focus to the originating card when the detail is closed via keyboard.
- Forwards a ref to the
Linkcomponent so the autoFocus behavior on the action button works for link-style actions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webapp/src/projects.tsx | Adds focus-restoration helpers, reorders CloseButton in detail views, threads optional restoreFocus through closeDetail, and passes linkRef to Link when autofocusing. |
| theme/home.less | Re-adds selected-card border/arrow styling and extends focus-visible styling to search and go-back buttons. |
| react-common/components/controls/Link.tsx | Converts Link to React.forwardRef to allow callers to focus the underlying anchor. |
srietkerk
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix microsoft/pxt-microbit#6842
fix microsoft/pxt-microbit#6826
fix microsoft/pxt-microbit#6810
fix microsoft/pxt-microbit#6841
last commit minor improvement noticed re: above, since tab order was weird hadn't come up before; navigate user focus back to where the detailview was sourced from when closed via keyboard event on closebutton. Current behavior is weird / inconsistent, focus goes away and browser does it's best to restore (usually going to first card in next row, roughly)