Improve screen reader and keyboard navigation experience for sound effect editor#11300
Open
microbit-robert wants to merge 1 commit into
Open
Improve screen reader and keyboard navigation experience for sound effect editor#11300microbit-robert wants to merge 1 commit into
microbit-robert wants to merge 1 commit into
Conversation
riknoll
reviewed
May 14, 2026
Member
riknoll
left a comment
riknoll
left a comment
There was a problem hiding this comment.
Minor nitpicks! LGTM otherwise!
| outline: 3px solid var(--pxt-focus-border) !important; | ||
| outline-offset: 3px; | ||
| .common-button.sound-effect-play-button { | ||
| &[aria-selected="true"],&:focus-visible { |
Member
There was a problem hiding this comment.
Suggested change
| &[aria-selected="true"],&:focus-visible { | |
| &[aria-selected="true"], &:focus-visible { |
| const ref = React.useRef<HTMLDivElement>(null); | ||
|
|
||
| const handlePreviewButtonClick = (index: number) => { | ||
| ref.current?.focus({preventScroll: true}); |
Member
There was a problem hiding this comment.
Suggested change
| ref.current?.focus({preventScroll: true}); | |
| ref.current?.focus({ preventScroll: true }); |
| onFocus={focusSelectOrPlayElement}> | ||
| role="grid" | ||
| aria-activedescendant={activeDescendant} | ||
| onFocus={e => { setGridFocused(true); focusSelectOrPlayElement(e); }} |
Member
There was a problem hiding this comment.
don't like cramming multi-line handlers inline like this, let's pull it up into a variable. same for keydown below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes various keyboard navigation and screen reader improves to the sound effect field editor.
Editor tab:
Gallery tab: