Warn when "Custom" binding username claim becomes unsupported - #3405
Open
Patryk Mroczko (patmr7) wants to merge 1 commit into
Open
Warn when "Custom" binding username claim becomes unsupported#3405Patryk Mroczko (patmr7) wants to merge 1 commit into
Patryk Mroczko (patmr7) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an admin-facing warning when the “Binding username claim” setting is stored as Custom but becomes unsupported under the currently configured IdP type when local_o365 user sync is enabled, helping prevent silent misconfiguration after settings changes.
Changes:
- Add a new validation function to warn admins when a stored “Custom” binding username claim becomes unsupported.
- Invoke this validation during OIDC auth settings validation.
- Trigger this validation when local_o365 user sync settings are updated, and add the corresponding language string.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| local/o365/settings.php | Attaches an updated-callback to user sync settings to run the new binding-claim validation when sync settings change. |
| auth/oidc/lib.php | Adds auth_oidc_validate_binding_username_claim() and calls it from auth settings validation to emit a warning when configuration becomes unsupported. |
| auth/oidc/lang/en/auth_oidc.php | Adds the warning message string shown to admins. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.