Warn when "Custom" binding username claim becomes unsupported - #3403
Open
Patryk Mroczko (patmr7) wants to merge 1 commit into
Open
Warn when "Custom" binding username claim becomes unsupported#3403Patryk Mroczko (patmr7) wants to merge 1 commit into
Patryk Mroczko (patmr7) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an admin warning when the “Binding username claim” configuration is set to “Custom” in a scenario where that option is no longer supported (Microsoft IdP types with local_o365 user sync enabled), and wires the validation into relevant settings updates.
Changes:
- Adds a new validation function to warn admins when an unsupported “Custom” binding username claim is configured.
- Triggers the validation when OIDC auth settings change and when local_o365 user sync settings are updated.
- Introduces a new English language string for the warning message.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| local/o365/settings.php | Adds an updated-callback to user sync settings to run the binding-claim validation after changes. |
| auth/oidc/lib.php | Adds the warning/validation function and invokes it during auth settings validation. |
| auth/oidc/lang/en/auth_oidc.php | Adds the warning text shown to admins. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.