Skip to content

Warn when "Custom" binding username claim becomes unsupported - #3403

Open
Patryk Mroczko (patmr7) wants to merge 1 commit into
MOODLE_502_STABLEfrom
wip-121467-m502
Open

Warn when "Custom" binding username claim becomes unsupported#3403
Patryk Mroczko (patmr7) wants to merge 1 commit into
MOODLE_502_STABLEfrom
wip-121467-m502

Conversation

@patmr7

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an admin warning when the “Binding username claim” configuration is set to “Custom” in a scenario where that option is no longer supported (Microsoft IdP types with local_o365 user sync enabled), and wires the validation into relevant settings updates.

Changes:

  • Adds a new validation function to warn admins when an unsupported “Custom” binding username claim is configured.
  • Triggers the validation when OIDC auth settings change and when local_o365 user sync settings are updated.
  • Introduces a new English language string for the warning message.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
local/o365/settings.php Adds an updated-callback to user sync settings to run the binding-claim validation after changes.
auth/oidc/lib.php Adds the warning/validation function and invokes it during auth settings validation.
auth/oidc/lang/en/auth_oidc.php Adds the warning text shown to admins.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread auth/oidc/lib.php
Comment thread auth/oidc/lib.php
@patmr7 Patryk Mroczko (patmr7) added this to the 2026-03 milestone Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants