Skip to content

Add support for .NET 10#476

Merged
jasongin merged 11 commits into
microsoft:mainfrom
dotnetjunky:main
May 20, 2026
Merged

Add support for .NET 10#476
jasongin merged 11 commits into
microsoft:mainfrom
dotnetjunky:main

Conversation

@dotnetjunky
Copy link
Copy Markdown
Contributor

@dotnetjunky dotnetjunky commented May 19, 2026

Attempt to add support for .NET. I used Github Copilot to ask it to generate the changes based on the previous commit to add support for .NET 9.

dotnetjunky and others added 4 commits May 19, 2026 06:03
@dotnetjunky
Add .NET 10 support
05a7387 
Following the pattern of bb2575c (Add .NET 9 support), this adds .NET 10
as the latest supported target framework while retaining .NET 8 support.

Changes:
- Add net10.0 to CI/CD build and test matrices (GitHub Actions, ADO)
- Install .NET 10 SDK in workflows; add .NET 9 install for older test targets
- Update AOT build moniker to net10.0
- Update benchmark and VS Code task defaults to net10.0
- Update documentation to list net10.0 as supported
- Fix stale comments referencing .NET 6 in Generator csproj/targets

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnetjunky
Fix minor typo
b216f6b
@dotnetjunky
fix formatting
724af5d
@dotnetjunky
undo changes to aot
693e567
@dotnetjunky dotnetjunky mentioned this pull request May 19, 2026
Open
@dotnetjunky dotnetjunky marked this pull request as ready for review May 19, 2026 21:05
@dotnetjunky
Copy link
Copy Markdown
Contributor Author

dotnetjunky commented May 19, 2026

The build is failing because the "dotnet build" step is trying to download the nuget package "Microsoft.NET.ILLink.Tasks" from the react-native-public feed, but the .nupkg file requires authentication.

@dotnetjunky
Copy link
Copy Markdown
Contributor Author

dotnetjunky commented May 19, 2026

@jasongin @vmoroz Could you please take a look?

vmoroz
vmoroz reviewed May 20, 2026
View reviewed changes
Comment thread .npmrc
vmoroz
vmoroz reviewed May 20, 2026
View reviewed changes
Comment thread src/NodeApi/Runtime/PooledBuffer.cs
vmoroz
vmoroz reviewed May 20, 2026
View reviewed changes
Comment thread docs/scenarios/js-dotnet-module.md
@vmoroz
Copy link
Copy Markdown
Member

vmoroz commented May 20, 2026

@dotnetjunky , it is not clear from the change the main purpose of the PR.
Are you adding support for .Net 10 or replacing .Net 9 with .Net 10?
Please carefully review the changes to the pipeline files.

@vmoroz
Copy link
Copy Markdown
Member

vmoroz commented May 20, 2026 •
edited
Loading

I will update the NuGet feed to supply missing packages.
Never mind - it seems that you already updated them.

@dotnetjunky
Copy link
Copy Markdown
Contributor Author

dotnetjunky commented May 20, 2026

@dotnetjunky , it is not clear from the change the main purpose of the PR. Are you adding support for .Net 10 or replacing .Net 9 with .Net 10? Please carefully review the changes to the pipeline files.

@vmoroz The goal is to add support for .NET 10, not replacing .NET 9. There's a few places where we only build the project with the latest framework, so I replaced v9 with v10. Please point out which file I did it wrong.

vmoroz
vmoroz approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasongin jasongin merged commit f316e07 into microsoft:main May 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoroz vmoroz vmoroz approved these changes

@jasongin jasongin jasongin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotnetjunky @vmoroz @jasongin