Skip to content

Use segment number from SegmentInfo#420

Merged
makubacki merged 1 commit into
microsoft:release/202511from
cmruffin:personal/v-chrruffin/test-point
Jun 22, 2026
Merged

Use segment number from SegmentInfo#420
makubacki merged 1 commit into
microsoft:release/202511from
cmruffin:personal/v-chrruffin/test-point

Conversation

@cmruffin

@cmruffin cmruffin commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description

The segment index is not always the segment number, which can lead to an invalid access.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Unit test on AARCH64 platform.

Integration Instructions

NA

@mu-automation mu-automation Bot added the impact:non-functional Does not have a functional impact label May 4, 2026
@antklein

Copy link
Copy Markdown
Contributor

@makubacki, can we get your help reviewing this change?

… an invalid access.

Signed-off-by: Chris Ruffin <cruffin@millcore.com>
@makubacki makubacki force-pushed the personal/v-chrruffin/test-point branch from cc571b2 to 0ba0240 Compare June 22, 2026 23:07
@makubacki makubacki requested review from apop5 and vineelko June 22, 2026 23:08
@makubacki makubacki removed the impact:non-functional Does not have a functional impact label Jun 22, 2026
@makubacki makubacki enabled auto-merge (squash) June 22, 2026 23:10
@makubacki makubacki merged commit 0f4c6a7 into microsoft:release/202511 Jun 22, 2026
23 checks passed
@antklein

Copy link
Copy Markdown
Contributor

FYI, upleveled this PR. MinPlatformPkg/TestPointCheckLib: Use the correct Pci Segment number for TestPointCheckPciBusMaster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants