Skip to content

[CHERRY-PICK] MdeModulePkg: Add platform limit for size in Resizable BAR#1808

Merged
makubacki merged 1 commit into
microsoft:release/202511from
Gowtham-Manikandan:MdeModulePkg-Pcd-Fix
May 28, 2026
Merged

[CHERRY-PICK] MdeModulePkg: Add platform limit for size in Resizable BAR#1808
makubacki merged 1 commit into
microsoft:release/202511from
Gowtham-Manikandan:MdeModulePkg-Pcd-Fix

Conversation

@Gowtham-Manikandan
Copy link
Copy Markdown

@Gowtham-Manikandan Gowtham-Manikandan commented May 28, 2026

Description

Added PcdPcieResizableBarMaxSize to avoid build issues in latest BKC integration.


Resizable BAR driver selects max available BAR size to configure for use. It may happen that some PCIe device declare support for size that exceeds processor address width. Platform needs a way to define the max size it can accept. This change introduce PCD called PcdPcieResizableBarMaxSize. It is dynamic PCD where platform can provide its limit for BAR size. Such PCD can be also controlled with a configuration knob.

(cherry picked from commit 24eddc6)

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested by local build of OKS Platform

Integration Instructions

N/A

@mu-automation
Copy link
Copy Markdown
Contributor

mu-automation Bot commented May 28, 2026

✅ QEMU Validation Passed

Source Dependencies

Repository Commit
mu_basecore c92403a
mu_tiano_platforms de8be29

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ✅ success ✅ success 0m 19s Build Logs Boot Logs
SBSA DEBUG ✅ success ✅ success 0m 34s Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/26585556018

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202511@cd8fb3a). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202511    #1808   +/-   ##
=================================================
  Coverage                  ?    1.84%           
=================================================
  Files                     ?     1151           
  Lines                     ?   376555           
  Branches                  ?     3196           
=================================================
  Hits                      ?     6936           
  Misses                    ?   369563           
  Partials                  ?       56           
Flag Coverage Δ
FmpDevicePkg 9.53% <ø> (?)
MdeModulePkg 1.58% <ø> (?)
NetworkPkg 0.55% <ø> (?)
PolicyServicePkg 30.42% <ø> (?)
SecurityPkg 1.59% <ø> (?)
UefiCpuPkg 4.78% <ø> (?)
UnitTestFrameworkPkg 11.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makubacki makubacki requested review from apop5 and kuqin12 May 28, 2026 15:29
Resizable BAR driver selects max available BAR size to configure for use.
It may happen that some PCIe device declare support for size that exceeds
processor address width. Platform needs a way to define the max size it
can accept. This change introduce PCD called PcdPcieResizableBarMaxSize.
It is dynamic PCD where platform can provide its limit for BAR size.
Such PCD can be also controlled with a configuration knob.

Signed-off-by: Jacek Kolakowski <Jacek.Kolakowski@intel.com>
(cherry picked from commit 24eddc6)
@makubacki makubacki force-pushed the MdeModulePkg-Pcd-Fix branch from cc99e53 to c92403a Compare May 28, 2026 15:29
@makubacki makubacki merged commit 0749d6b into microsoft:release/202511 May 28, 2026
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants