Add experimental TDS performance baseline - #303
Draft
Saurabh Singh (saurabh500) wants to merge 1 commit into
Draft
Add experimental TDS performance baseline#303Saurabh Singh (saurabh500) wants to merge 1 commit into
Saurabh Singh (saurabh500) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5bcfe214-06ab-401e-9b36-bbba2e053d19
This was referenced Aug 15, 2026
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changes
Summary
mssql-tds/src/connection/tds_client.rsmssql-tds/src/datatypes/decoder.rs🔗 Quick Links |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates an experimental, independently reviewable performance baseline on current
mainby duplicating the PR-level changes from #291 and the updated #299.ResultSetrow reads through native futures and keeps row-fetch futures within the size budgetmainbehavior unrelated to the source changesThis is a separate performance exploration. It does not replace, close, retarget, or modify #291 or #299, and it is not part of stack #287.
Standalone adaptation: #291's generic
RowWriterdispatch depends onAnyTransportfrom its separate native-stack prerequisite. Currentmainintentionally storesBox<dyn TdsTransport>, so this layer retains the boxed transport and dynamic writer boundary while preserving #291's nativeResultSetfuture forwarding, future-size checks, and explicit error cleanup.Related Issues
Source context only (does not close either PR):
Checklist
cargo bfmtpassescargo bclippypassescargo btestpasses (1666/1670mssql-tdslibrary tests pass; four unrelated certificate tests cannot find the repository's absenttests/test_certificates/valid_cert.{pem,der}fixtures)