Keep no-op comment runs out of the PR coverage cancellation group - #300
Draft
Saurabh Singh (saurabh500) with Copilot wants to merge 2 commits into
Draft
Keep no-op comment runs out of the PR coverage cancellation group#300Saurabh Singh (saurabh500) with Copilot wants to merge 2 commits into
Saurabh Singh (saurabh500) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: saurabh500 <1623701+saurabh500@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cancellation of PR coverage run on comments
Keep no-op comment runs out of the PR coverage cancellation group
Aug 15, 2026
Copilot started reviewing on behalf of
Saurabh Singh (saurabh500)
August 15, 2026 15:43
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents no-op comment-triggered coverage runs from cancelling active PR coverage runs.
Changes:
- Gives skipped runs unique concurrency groups.
- Preserves per-PR cancellation for real coverage runs.
- Mirrors the job execution predicate in concurrency handling.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Code Coveragetriggers on everyissue_comment, and GitHub resolvesconcurrencyat run creation — before the jobif:runs. So an ordinary review comment created a run that joinedpr-coverage-<n>, cancelled the in-flightpull_requestrun mid-wait (the artifact wait is up to 1h15m), and then concludedskippeditself. Any PR under review effectively lost its coverage run and showed a red check.Changes
coverage-reportjob will skip get a unique-noop-<run_id>suffix, so they share a group with nothing and cancel nothing.cancel-in-progress.if:, not just the/coverageprefix, so forkpull_requestevents and non-maintainer comments are also treated as no-ops. A comment marks the two as needing to stay in sync.Skipped runs still appear as
skippedexactly as before; only their group membership changes. The folded scalar collapses to a single-line expression, so no newlines leak into the group value.