Reduce duplication in nextest/ODBC CI target lists and arm64 test templates - #154
Draft
Saurabh Singh (saurabh500) with Copilot wants to merge 2 commits into
Draft
Reduce duplication in nextest/ODBC CI target lists and arm64 test templates#154Saurabh Singh (saurabh500) with Copilot wants to merge 2 commits into
Saurabh Singh (saurabh500) with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Refactor ODBC CI target lists and arm64 test template to reduce duplication
Reduce duplication in nextest/ODBC CI target lists and arm64 test templates
Jul 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces CI matrix duplication by standardizing target parameters and documenting synchronized ARM64 paths.
Changes:
- Converts x64 matrix templates to target lists.
- Reuses distro lists via YAML anchors.
- Documents duplicated ARM64 step blocks.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.pipeline/templates/validation-stages.yml |
Shares distro target lists between architectures. |
.pipeline/templates/test-matrix-template.yml |
Generates the amd64 matrix from targets. |
.pipeline/templates/test-matrix-template-arm64.yml |
Documents synchronized ARM64 paths. |
.pipeline/templates/test-matrix-template-alpine.yml |
Generates the Alpine matrix from targets. |
.pipeline/templates/test-matrix-template-alpine_arm64.yml |
Documents synchronized Alpine ARM64 paths. |
| artifactName: 'Build_Linux' | ||
| matrix: | ||
| Alpine3_18: | ||
| targets: &alpine_targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Alpine and deb/rhel distro target lists in
validation-stages.ymlwere written out twice each — once for x64 stages (matrix format) and once for arm64 stages (targets-list format). Adding or removing a distro required editing multiple places and invited drift.Changes
Unified parameter format for x64 matrix templates
test-matrix-template.ymlandtest-matrix-template-alpine.yml: replacedmatrix: {}parameter withtargets: [](matching the existing arm64 template contract). The ADOstrategy.matrixis generated internally via${{ each target in parameters.targets }}, so runtime variables$(container)and$(entry)in script steps are unchanged.Single source of truth for target lists (
validation-stages.yml)YAML anchors replace the four inline duplicate lists:
Same pattern for
&deb_rhel_targets/*deb_rhel_targetsacrossTest_amd64andTest_arm64. Adding or removing a distro is now a single-location edit.Sync comments on arm64 templates
Added comments to both
test-matrix-template-arm64.ymlandtest-matrix-template-alpine_arm64.ymlnoting that the shared-mode and per-job-modesteps:blocks are structurally identical — differing only in variable sourcing ($(…)runtime vs${{ target.* }}compile-time) — and must be kept in sync. ADO template constraints prevent further factoring.