Defend against missing files in the hashing logic#907
Open
dobesv wants to merge 3 commits into
Open
Conversation
ecraig12345
approved these changes
Apr 9, 2026
If a file is missing while calculating file hashes, use stub values instead of exiting with an error.
dobesv
force-pushed
the
hash-file-missing-fixup
branch
from
f2cc661 to
50487ed
Compare
Contributor
Author
|
@ecraig12345 I see you approved this but did not merge it - am I supposed to merge it after ? I don't think I am able. Or are you waiting for someone else to merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a file is missing while calculating file hashes, use stub values instead of exiting with an error.
I added this because I was occasionally getting errors from this code about the file not being there and lage would exit, I think this may be caused by my changes in #867 , which allows inputs to specify exact files rather than globs so there could be a file listed as an input that doesn't exist at the time of the build.