Move common logic in virt-launcher to virt-launcher-common pkg #20
Move common logic in virt-launcher to virt-launcher-common pkg #20harshitgupta1337 wants to merge 21 commits into
Conversation
Co-authored-by: Harshit Gupta <guptaharshit@microsoft.com>
JocelynBerrendonner
left a comment
There was a problem hiding this comment.
This change is really massive. How can we stage these changes to prevent such a massive PR?
@JocelynBerrendonner I agree that the PR has a very large number of files that are changed. The vast majority of files updated simply have changes to |
What this PR does
Before this PR: The logic in virt-launcher that is agnostic of the underlying virtualization stack (e.g., gRPC server for managing VM, DomainManager interface, NotifyClient) was in the same package as the virtualization-stack-specific code.
After this PR: Virtualization-stack-agnostic code has been moved to a separate package called
virt-launcher-common. The libvirt/qemu/kvm-specific logic in virt-launcher is left in thevirt-launcherpackage.virt-launcher-commondoes not depend on any code in the libvirt-specificvirt-launcherpackage.