Skip to content

fix(build): pin tmp >=0.2.6 to resolve GHSA-ph9p-34f9-6g65#1686

Open
WilliamBerryiii wants to merge 1 commit into
mainfrom
fix/npm-audit-tmp-override
Open

fix(build): pin tmp >=0.2.6 to resolve GHSA-ph9p-34f9-6g65#1686
WilliamBerryiii wants to merge 1 commit into
mainfrom
fix/npm-audit-tmp-override

Conversation

@WilliamBerryiii
Copy link
Copy Markdown
Member

Pull Request

Description

Pin transitive tmp dependency to >=0.2.6 via the root overrides block to resolve GHSA-ph9p-34f9-6g65 (CWE-22 arbitrary path traversal via symbolic link, high severity).

tmp@0.2.5 is pulled in transitively through @vscode/vsce@3.9.1 → tmp. Rather than bumping @vscode/vsce (which could carry unrelated breaking changes), the fix uses the repository's existing overrides pattern alongside other pinned transitive deps (basic-ftp, undici, yauzl, etc.).

Related Issue(s)

Resolves the npm Security Audit CI failure observed on recent PRs (e.g. #1497).

Type of Change

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)

Infrastructure & Configuration:

  • Security configuration
  • Dependency update

Testing

  • npm install succeeded; package-lock.json regenerated.

  • npm ls tmp --all shows the override is active:

    hve-core@3.3.101
    └─┬ @vscode/vsce@3.9.1
      └── tmp@0.2.6 overridden
    
  • npm run audit:npm (audit-ci) → exit code 0, "Passed npm security audit", 0 vulnerabilities across all severities.

Checklist

Required Checks

  • Files follow existing naming conventions
  • Changes are backwards compatible

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues — tmp@0.2.6 is the upstream-published patched release for GHSA-ph9p-34f9-6g65.

- add tmp override in package.json to force @vscode/vsce dep onto patched 0.2.6
- regenerate package-lock.json; npm audit now reports 0 vulnerabilities

🔒 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii requested a review from a team as a code owner May 28, 2026 03:21
@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/tmp 0.2.6 🟢 4
Details
CheckScoreReason
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 56 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 5
Code-Review⚠️ 1Found 2/18 approved changesets -- score normalized to 1
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • package-lock.json

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.73%. Comparing base (d307f8a) to head (2c05c28).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   85.74%   85.73%   -0.01%     
==========================================
  Files          81       81              
  Lines       11783    11783              
==========================================
- Hits        10103    10102       -1     
- Misses       1680     1681       +1     
Flag Coverage Δ
pester 84.02% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot mentioned this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants