Skip to content

prevent overly large forecasts #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mitokic wants to merge 2 commits into
base: main
Choose a base branch
from
Open

prevent overly large forecasts #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2265528
prevent overly large forecasts which contribute to writing to disk is…
mitokic Jan 17, 2024
d667461
update version
mitokic Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: finnts
Title: Microsoft Finance Time Series Forecasting Framework
Version: 0.4.0
Version: 0.4.0.9000
Authors@R:
c(person(given = "Mike",
family = "Tokic",
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# finnts 0.4.0.9000 (DEVELOPMENT VERSION)

## Bug Fixes

- Issue when writing extremely large forecasts to disk

# finnts 0.4.0

## Improvements
Expand Down
4 changes: 4 additions & 0 deletions R/train_models.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,10 @@ train_models <- function(run_info,
tidyr::unite(col = "Model_ID", c("Model_Name", "Model_Type", "Recipe_ID"), sep = "--", remove = FALSE) %>%
dplyr::group_by(Combo_ID, Model_ID, Train_Test_ID) %>%
dplyr::mutate(Horizon = dplyr::row_number()) %>%
dplyr::ungroup() %>%
dplyr::rowwise() %>%
dplyr::mutate(Forecast = ifelse(Forecast > 1000000000000000, 1000000000000000, Forecast)) %>%
dplyr::mutate(Forecast = ifelse(Forecast < -1000000000000000, -1000000000000000, Forecast)) %>%
dplyr::ungroup()

if (unique(final_forecast_tbl$Combo_ID) == "All-Data") {
Expand Down