feat(fast-test-harness): propagate shadow DOM options through template generation and SSR#7519
Open
radium-v wants to merge 4 commits into
Open
feat(fast-test-harness): propagate shadow DOM options through template generation and SSR#7519radium-v wants to merge 4 commits into
radium-v wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds support for shadow DOM options (e.g.
delegatesFocus,mode) throughout the test harness template generation and SSR rendering pipeline, so SSR-rendered components produce declarative shadow roots that match their client-side definitions.Also adds a
urlproperty toSSRFixturefor tests that need to control the page URL during SSR rendering.Key changes:
shadowrootmode/shadowrootdelegatesfocusattributes via a pluggable resolver (resolveShadowOptions).SSRFixturegains aurloption.📑 Test Plan
generate-templatesandgenerate-webui-templates, plus SSRrenderbehavior.SSRFixtureurlproperty.npm run test -w @microsoft/fast-test-harness.✅ Checklist
General
$ npm run change