Introduce Finance Calculator#1306
Closed
Chips1234 wants to merge 2 commits into
Closed
Conversation
Note: Tip calculator is not done yet!! If anyone can help me with BooltoVisibility converter, that would be great!
Can't forget about the text in the contextmenu!
Contributor
Author
|
Can someone take a look? |
Member
|
Thanks for jumping into the code here--but I think there are many undecided details about how the feature should work which need to be resolved before looking at the code. For example, I'm not sure that we should group both the compound interest and tips calculators under one "Finance" mode. Let's follow this project's new feature process and work on a spec document which describes how the feature will work. The spec document can be changed faster than the code can and it's easier to share more widely for feedback. Once that document looks good we can move into the "Implementation" phase and reopen this PR. |
Contributor
Author
|
Spec pull made! Look at the spec and go give some feedback! |
Contributor
Author
Contributor
Contributor
Author
|
Alright. Will look into it. Thanks
|
Contributor
Author
|
Hmm... Still happens @joseartrivera |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


As of July 08th, 2020: The tips calculator is not done yet!! If anyone can help me with the BooltoVisibility converter, that would be great! (P.s. this is still a draft pr)
Fixes #806 .
Description of the changes:
How changes were validated:
Note: In code, Financial mode is always mentioned as "FinanceCalculator" for shortness and consistency.
Also, if you have an idea or can tell me how to use the BooleanToVisibility converter that would be nice. Thanks.