Skip to content

Introduce Finance Calculator#1306

Closed
Chips1234 wants to merge 2 commits into
microsoft:masterfrom
Chips1234:FinancialCalculator
Closed

Introduce Finance Calculator#1306
Chips1234 wants to merge 2 commits into
microsoft:masterfrom
Chips1234:FinancialCalculator

Conversation

@Chips1234
Copy link
Copy Markdown
Contributor

As of July 08th, 2020: The tips calculator is not done yet!! If anyone can help me with the BooltoVisibility converter, that would be great! (P.s. this is still a draft pr)

Fixes #806 .

Description of the changes:

  • A new calculation mode, "Financial"
  • Includes Compound Interest Calculator
  • A tip calculation mode (Not started as of 08th July)

How changes were validated:

  • Manual

Note: In code, Financial mode is always mentioned as "FinanceCalculator" for shortness and consistency.
Also, if you have an idea or can tell me how to use the BooleanToVisibility converter that would be nice. Thanks.

Chips1234 added 2 commits July 8, 2020 19:05
Note: Tip calculator is not done yet!! If anyone can help me with BooltoVisibility converter, that would be great!
Can't forget about the text  in the contextmenu!
@Chips1234 Chips1234 marked this pull request as ready for review July 10, 2020 19:42
@Chips1234
Copy link
Copy Markdown
Contributor Author

Can someone take a look?

@mcooley
Copy link
Copy Markdown
Member

mcooley commented Jul 11, 2020

Thanks for jumping into the code here--but I think there are many undecided details about how the feature should work which need to be resolved before looking at the code. For example, I'm not sure that we should group both the compound interest and tips calculators under one "Finance" mode.

Let's follow this project's new feature process and work on a spec document which describes how the feature will work. The spec document can be changed faster than the code can and it's easier to share more widely for feedback. Once that document looks good we can move into the "Implementation" phase and reopen this PR.

@mcooley mcooley closed this Jul 11, 2020
@Chips1234
Copy link
Copy Markdown
Contributor Author

Spec pull made! Look at the spec and go give some feedback!

@Chips1234
Copy link
Copy Markdown
Contributor Author

Also, can anyone help me (see gif below, once one grid is loaded, another should collapse but that doesn't happen)?
Calculator Financial Mode Change

@joseartrivera
Copy link
Copy Markdown
Contributor

joseartrivera commented Jul 14, 2020

Also, can anyone help me (see gif below, once one grid is loaded, another should collapse but that doesn't happen)?
Calculator Financial Mode Change

I think its a problem with this part of the code, you are setting the DataContext to be the GraphingCalcViewModel instead of your view model.

m_financeCalculator->DataContext = m_model->GraphingCalcViewModel;

@Chips1234
Copy link
Copy Markdown
Contributor Author

Chips1234 commented Jul 14, 2020 via email

@Chips1234
Copy link
Copy Markdown
Contributor Author

Chips1234 commented Jul 15, 2020

Hmm... Still happens @joseartrivera
Calculator Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support basic interest rate calculations

3 participants