Simple storage merging for base configs API.#809
Open
cwize1 wants to merge 1 commit into
Open
Conversation
1. Allow storage to be specified one time in the config tree. This covers a lot of uses cases, without the need for more complex merging logic. 2. Merge preview feature flags from base configs. 2. For the test config files that have distro variations, move common settings into a base config. This helps significantly reduce config duplication. 3. For the image creation test config files, always use a 3 GiB disk size, to avoid unneccessary differences between distros. 4. In the `TestOutputAndInjectArtifacts` and `TestOutputAndInjectArtifactsCosi` test, don't create a temporary copy of the config file. This makes it easier to use the base configs API in the config files. 5. For the `create-minimal-os` config files, move the common list of packages into a package list file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow storage to be specified one time in the config tree. This covers a lot of uses cases, without the need for more complex merging logic.
Merge preview feature flags from base configs.
For the test config files that have distro variations, move common settings into a base config. This helps significantly reduce config duplication.
For the image creation test config files, always use a 3 GiB disk size, to avoid unneccessary differences between distros.
In the
TestOutputAndInjectArtifactsandTestOutputAndInjectArtifactsCositest, don't create a temporary copy of the config file. This makes it easier to use the base configs API in the config files.For the
create-minimal-osconfig files, move the common list of packages into a package list file.Checklist