Bump tmp to 0.2.6 to resolve the two open tmp Dependabot alerts#17594
Conversation
Closes the two open Dependabot alerts on the 'tmp' package by pinning it to a patched version via npm overrides / yarn resolutions. Alerts addressed: - #1175 tmp <0.2.6 path traversal (playground Angular package-lock.json) - #1174 tmp <0.2.6 path traversal (extension/yarn.lock) Both are dev-only transitive dependencies (extension via @vscode/test-electron, playground via karma). Patch bump only - no public API changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17594Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17594" |
There was a problem hiding this comment.
Pull request overview
Bumps the transitive tmp dependency to >= 0.2.6 in two manifests to close two open Dependabot alerts (GHSA-ph9p-34f9-6g65, path traversal). tmp is a dev-only transitive dep (via @vscode/vsce in the extension, via karma in the Angular playground); no source code uses it directly.
Changes:
- Pin
tmpto0.2.6inextension/package.jsonresolutions and updateextension/yarn.lockaccordingly (resolved via the internal dnceng npm mirror). - Add
"tmp": "^0.2.6"tooverridesin the Angular playgroundpackage.jsonand regeneratepackage-lock.json(resolves to0.2.7).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extension/package.json | Adds tmp: 0.2.6 resolution pin. |
| extension/yarn.lock | Updates tmp entry to 0.2.6 via the dnceng feed. |
| playground/AspireWithJavaScript/AspireJavaScript.Angular/package.json | Adds tmp: ^0.2.6 override. |
| playground/AspireWithJavaScript/AspireJavaScript.Angular/package-lock.json | Updates resolved tmp to 0.2.7 from npmjs.org. |
Files not reviewed (1)
- playground/AspireWithJavaScript/AspireJavaScript.Angular/package-lock.json: Language not supported
|
❓ CLI E2E Tests unknown — 107 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26571470386 |
|
Status check (Dependabot alert sweep across all 4 Aspire repos): This PR + #17539 together close all 30 open Dependabot alerts on this repo. Coverage:
All 99 required checks are green on this PR as well, and it's in a |
…notes Documents the bump of the transitive tmp npm package (< 0.2.6 path traversal) addressed in microsoft/aspire#17594. The dependency is dev-only and not present in any published NuGet package. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Pull request created: #1123
|
|
📝 Documentation has been drafted in microsoft/aspire.dev#1123 targeting Added a 🔒 Security updates section to the Aspire 13.4 what's-new page noting that the Note This draft PR needs human review before merging. |
…release notes (#1123) * docs: note tmp security update (GHSA-ph9p-34f9-6g65) in 13.4 release notes Documents the bump of the transitive tmp npm package (< 0.2.6 path traversal) addressed in microsoft/aspire#17594. The dependency is dev-only and not present in any published NuGet package. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address review feedback (2 threads) - PRRT_kwDOQK_VN86FwICn: Remove the tmp security-update note from the Aspire 13.4 release notes because release/13.4 still resolves tmp to 0.2.5. - PRRT_kwDOQK_VN86Fvhxw: Remove the long added paragraph with the same section, resolving the wrapping concern. Verified against microsoft/aspire@11bea2e on branch release/13.4. Edited per the doc-writer skill. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: aspire-repo-bot[bot] <268009190+aspire-repo-bot[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: David Pine <7679720+IEvangelist@users.noreply.github.com>
Bump
tmpto0.2.6to resolve the two opentmpDependabot alertsSummary
Closes the two remaining open Dependabot alerts that are not covered by the existing dependabot group PR #17539. Both alerts are for the
tmppackage (< 0.2.6path traversal, GHSA-ph9p-34f9-6g65).Alerts addressed
extension/yarn.lock< 0.2.60.2.6playground/AspireWithJavaScript/AspireJavaScript.Angular/package-lock.json< 0.2.60.2.7How each manifest was updated
extension—tmpis transitive (via@vscode/test-electron). Added"tmp": "0.2.6"to the existingresolutionsblock inpackage.jsonand patched the singletmp@^0.2.3entry inyarn.lockto point attmp-0.2.6.tgz(resolved + sha1 integrity validated against the configuredpkgs.dev.azure.com/dncengmirror).yarn install --frozen-lockfilesucceeds.playground/AspireWithJavaScript/AspireJavaScript.Angular—tmpis transitive (viakarma). Added"tmp": "^0.2.6"to the existingoverridesblock inpackage.jsonand regeneratedpackage-lock.jsonvianpm install --package-lock-only --legacy-peer-deps(matching the lockfile''s prior generation flags). Only thetmpresolved version + integrity changes; the new resolved version is0.2.7(highest matching^0.2.6).Risk notes for reviewers
tmpis a dev-only transitive dependency in both manifests; not a direct dependency, not in a runtime/published artifact.0.2.5 → 0.2.6/0.2.7). No public API changes.npm_and_yarngroup), which addresses the other 32 open alerts (qs,ws,@nevware21/ts-utils,fast-uri,@babel/plugin-transform-modules-systemjs,next).Validation