More packages in dev containers#242
Closed
chhwang wants to merge 1 commit into
Closed
Conversation
chhwang
added a commit
that referenced
this pull request
Jun 12, 2026
Add BASE_IMAGE usage comments to Dockerfiles Document the `ARG BASE_IMAGE` default/override pattern in `base-dev-x.dockerfile` and `base-x.dockerfile`. `build.sh` overrides the default via `--build-arg` for each target; the default exists so standalone `docker build` works without `--build-arg`. Comments make this relationship explicit. Extracted from PR #242. That PR removed the defaults entirely, which would break standalone builds; this PR keeps defaults and adds documentation instead. Functional package additions (clang-format, torch, black) deferred as optional follow-up. Files changed: - `docker/base-dev-x.dockerfile` — 3-line comment added (lines 1–3) - `docker/base-x.dockerfile` — 2-line comment added (lines 1–2) No functional changes. No Docker CI exists; hadolint clean.
Contributor
Author
|
Superseded by #261, which adds BASE_IMAGE usage comments to the dev dockerfiles (defaults preserved so standalone docker build still works). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.