A11y: Fix model picker Names, unique accelerator labels, and code sample Name length#611
Open
haoliuu wants to merge 6 commits into
Open
A11y: Fix model picker Names, unique accelerator labels, and code sample Name length#611haoliuu wants to merge 6 commits into
haoliuu wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses several accessibility (UIA) issues in AI Dev Gallery by ensuring key interactive UI elements have meaningful, non-null, and non-duplicated accessible names, and by reducing excessively long accessible names for code samples.
Changes:
- Adds explicit
AutomationProperties.Namevalues for model picker actions (e.g., Run sample / Add model / View documentation / Open AI Toolkit tool) and the API code sample surface. - Makes hardware-accelerator “More info” buttons uniquely named per accelerator (CPU/GPU/NPU/…).
- Adjusts Markdown list rendering to suppress decorative bullet UI from the accessibility tree (but see comment on list-item content visibility).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AIDevGallery/Utils/AppUtils.cs | Adds helper to generate unique accelerator “more info” UIA Names. |
| AIDevGallery/Pages/APIs/APIPage.xaml | Sets a concise UIA Name for the code sample ScrollViewer. |
| AIDevGallery/Controls/ModelSelectionControl.xaml | Uses the new accelerator “more info” UIA Name helper in templates. |
| AIDevGallery/Controls/ModelPicker/ModelPickerViews/OnnxPickerView.xaml | Adds UIA Names for action buttons and unique accelerator “more info” Names. |
| AIDevGallery/Controls/ModelPicker/ModelOrApiPicker.xaml | Adds unique accelerator “more info” Names and a UIA Name for “Run sample”. |
| AIDevGallery/Controls/ModelPicker/AddHFModelView.xaml | Uses the new accelerator “more info” UIA Name helper in templates. |
| AIDevGallery/Controls/Markdown/TextElements/MyList.cs | Excludes bullet glyphs from the accessibility tree (but currently also excludes list item content). |
| <controls:WrapPanel Orientation="Horizontal" ItemSpacing="12" LineSpacing="12"> | ||
| <Button | ||
| x:Name="OpenAIToolkitButton" | ||
| AutomationProperties.Name="Open AI Toolkit's Conversion tool" |
weiyuanyue
approved these changes
Jun 16, 2026
weiyuanyue
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for accessibility bugs reported against AI Dev Gallery. Each fix is in its own commit for independent review.
Fixes
Validation
Verified manually with Accessibility Insights for Windows on the reported pages; project builds clean for x64.