Tests: skip incomplete Unity installations when probing for an editor#482
Merged
sailro merged 1 commit intoJul 18, 2026
Merged
Conversation
On Windows, uninstall leftovers and stripped editors can remain under the Unity Hub folder with only a Resources subfolder. They register as valid installations and sort first, so FirstInstallation() returns a folder without managed assemblies and every test fails with missing references. Only register an installation if UnityEditor.dll is present, checking both the classic layout and the macOS 6000.3+ Resources/Scripting layout.
Member
|
Thank you for this contribution ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, uninstall leftovers and stripped editors can remain under the Unity Hub folder with only a
Resourcessubfolder (noManagedassemblies).UnityPathregisters them as valid installations, and since installations are enumerated in descending order, such a folder can end up first:FirstInstallation()then points to a folder without managed assemblies and every test fails with missingUnityEngine/UnityEditorreferences.Only register an installation if
UnityEditor.dllis actually present, checking both the classicManagedlayout and the macOS 6000.3+Resources/Scripting/Managedlayout (mirroringDiagnosticVerifier.UnityAssemblies()).