chore: dev to main merge#166
Open
Saswato-Microsoft wants to merge 7 commits into
Open
Conversation
…thentication on Jump VM via Azure Bastion
fix: Enable Microsoft Entra ID authentication for the jumpbox VM through Azure Bastion
…ure handling in SearchHelpers.ps1
fix: Update VM size and improve error handling for network instability
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds resiliency and BYO (bring-your-own) options to deployment/automation while updating jumpbox access to use Microsoft Entra ID via Azure Bastion.
Changes:
- Add transient HTTP/network retry + exponential backoff to OneLake indexing search requests.
- Support reusing an existing AI Foundry project via a new ARM parameter and derived “effective” outputs.
- Enable Entra ID sign-in for the jumpbox VM (AADLoginForWindows extension + RBAC assignment) and update docs accordingly.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/automationScripts/OneLakeIndex/SearchHelpers.ps1 | Adds transient failure detection and retry/backoff behavior for search requests. |
| infra/main.json | Adds optional existing AI project parameter, effective outputs, and jumpbox Entra ID extension/RBAC resources. |
| infra/main.bicepparam | Changes jumpbox provisioning credentials strategy and VM size; adds Entra ID sign-in guidance comment. |
| infra/main.bicep | Adds resources to enable Entra ID sign-in to the existing jumpbox VM via Bastion. |
| docs/post_deployment_steps.md | Updates Bastion connection steps to Entra ID authentication and swaps screenshot reference. |
| docs/deploymentguide.md | Updates env setup guidance, jumpbox auth narrative, and fixes “Accessing Private Resources” link text/target. |
| docs/deploy_app_from_foundry.md | Updates jumpbox access step to Entra ID authentication. |
| docs/ACCESSING_PRIVATE_RESOURCES.md | Rewrites jumpbox access/troubleshooting flow for Entra ID sign-in (no local creds). |
| README.md | Updates “Accessing Private Resources” doc link target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a major update to how users access the jumpbox VM in network-isolated deployments: sign-in is now performed via Microsoft Entra ID (formerly Azure AD) authentication through Azure Bastion, eliminating the need to manage local VM credentials. The infrastructure code, deployment parameters, and all related documentation have been updated to support and explain this new authentication flow. Additionally, the jumpbox VM is now automatically configured to enable Entra ID sign-in, and the deploying principal is granted the necessary RBAC role. Documentation has also been improved to clarify the process and remove references to local admin credentials.
The most important changes are:
Infrastructure & Authentication Flow:
infra/main.bicep,infra/main.json,infra/main.bicepparam) [1] [2] [3]infra/main.bicepparam)Documentation Updates:
docs/Accessing_Private_Resources.md,docs/deploymentguide.md,docs/post_deployment_steps.md,docs/deploy_app_from_foundry.md) [1] [2] [3] [4] [5]docs/Accessing_Private_Resources.md)Parameter and Output Changes:
vmUserName,vmAdminPassword) are now fixed and not user-configurable; guidance for setting them has been removed from documentation. (docs/deploymentguide.md,infra/main.bicepparam) [1] [2]infra/main.json) [1] [2]File and Reference Updates:
ACCESSING_PRIVATE_RESOURCES.md→Accessing_Private_Resources.md) throughout the documentation. (README.md,docs/deploymentguide.md) [1] [2]These changes make jumpbox access more secure and user-friendly, aligning with best practices for cloud-based authentication and RBAC.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information