Security: Unsafe HTML string construction in getDashboardHtml without CSP nonce on style-src#153
Open
tomaioo wants to merge 1 commit into
Conversation
The getDashboardHtml function in panel-html.ts constructs HTML by string concatenation including external style and script URIs. While a nonce is used for script-src, the style-src directive allows 'unsafe-inline' which bypasses CSP protection for styles. Additionally, the function uses String(styleUri) and String(scriptUri) which could potentially be exploited if the webview.asWebviewUri returns unexpected values. The 'unsafe-inline' in style-src allows attackers to inject styles if they can control any part of the HTML generation. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unsafe HTML string construction in getDashboardHtml without CSP nonce on style-src
Problem
Severity:
Medium| File:src/webview/panel-html.ts:L10The getDashboardHtml function in panel-html.ts constructs HTML by string concatenation including external style and script URIs. While a nonce is used for script-src, the style-src directive allows 'unsafe-inline' which bypasses CSP protection for styles. Additionally, the function uses String(styleUri) and String(scriptUri) which could potentially be exploited if the webview.asWebviewUri returns unexpected values. The 'unsafe-inline' in style-src allows attackers to inject styles if they can control any part of the HTML generation.
Solution
Remove 'unsafe-inline' from style-src and style-src-attr directives. Use nonces or hashes for all style sources. Validate that webview.asWebviewUri returns expected URI formats before string interpolation.
Changes
src/webview/panel-html.ts(modified)