Skip to content

Implement hybrid expandable panel to integrate YouTube search into Music Library tab #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Implement hybrid expandable panel to integrate YouTube search into Music Library tab #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1ec71f1
Initial plan
Copilot Dec 22, 2025
9c6095d
Add YouTube integration design options document
Copilot Dec 22, 2025
cbdd174
Add hybrid design option (expandable panel approach)
Copilot Dec 22, 2025
c143da1
Implement hybrid expandable YouTube panel in Music Library tab
Copilot Dec 22, 2025
abf30c0
Add comprehensive implementation documentation
Copilot Dec 22, 2025
21396b3
Fix action bar styling - use dark theme to match app UI
Copilot Dec 22, 2025
48cbff4
Fix YouTube panel styling to match dark theme
Copilot Dec 22, 2025
e2eb57d
Fix YouTube song import - add metadata review dialog support
Copilot Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
362 changes: 362 additions & 0 deletions docs/HYBRID_YOUTUBE_IMPLEMENTATION.md
View file
Open in desktop

Large diffs are not rendered by default.

396 changes: 396 additions & 0 deletions docs/YOUTUBE_INTEGRATION_DESIGN_OPTIONS.md
View file
Open in desktop

Large diffs are not rendered by default.

35 changes: 30 additions & 5 deletions src/Muine.App/ViewModels/MainWindowViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,15 @@ public MainWindowViewModel()
_mprisService.PreviousRequested += (s, e) => _ = PlayPreviousCommand.ExecuteAsync(null);

// Initialize view models
MusicLibraryViewModel = new MusicLibraryViewModel(_databaseService);
MusicLibraryViewModel = new MusicLibraryViewModel(_databaseService, _youtubeService, _taggingQueue, managedLibraryService, _metadataService);
PlaylistViewModel = new PlaylistViewModel();
RadioViewModel = new RadioViewModel(_radioStationService, _radioMetadataService, _radioBrowserService);
YouTubeSearchViewModel = new YouTubeSearchViewModel(_youtubeService, _databaseService, _taggingQueue, managedLibraryService, _metadataService);

// Subscribe to library events
MusicLibraryViewModel.SongsAddedToLibrary += OnYouTubeSongsAddedToLibrary;
MusicLibraryViewModel.YouTubeSongNeedsMetadataReview += OnYouTubeSongNeedsMetadataReview;

// Subscribe to YouTube events
YouTubeSearchViewModel.SongsAddedToLibrary += OnYouTubeSongsAddedToLibrary;
YouTubeSearchViewModel.YouTubeSongNeedsMetadataReview += OnYouTubeSongNeedsMetadataReview;
Expand Down Expand Up @@ -781,13 +785,29 @@ private void OnYouTubeSongNeedsMetadataReview(object? sender, YouTubeSongEventAr
{
// Download happens here, AFTER user has selected metadata
// This provides responsive UI - user sees results immediately
await YouTubeSearchViewModel!.CompleteYouTubeImportAsync(e.Song, e.YouTubeId);
// Determine which ViewModel triggered the event
if (sender == MusicLibraryViewModel)
{
await MusicLibraryViewModel!.CompleteYouTubeImportAsync(e.Song, e.YouTubeId);
}
else if (sender == YouTubeSearchViewModel)
{
await YouTubeSearchViewModel!.CompleteYouTubeImportAsync(e.Song, e.YouTubeId);
}
}
else
{
// User skipped - no download needed, nothing to clean up
YouTubeSearchViewModel!.StatusMessage = "Import cancelled";
YouTubeSearchViewModel.IsSearching = false;
if (sender == MusicLibraryViewModel)
{
MusicLibraryViewModel!.YoutubeStatusMessage = "Import cancelled";
MusicLibraryViewModel.IsYouTubeSearching = false;
}
else if (sender == YouTubeSearchViewModel)
{
YouTubeSearchViewModel!.StatusMessage = "Import cancelled";
YouTubeSearchViewModel.IsSearching = false;
}
}
}
}
Expand All @@ -797,7 +817,12 @@ private void OnYouTubeSongNeedsMetadataReview(object? sender, YouTubeSongEventAr
LoggingService.Error("Failed to open metadata review dialog for YouTube song", ex, "MainWindowViewModel");
StatusMessage = "Error reviewing YouTube song metadata";

if (YouTubeSearchViewModel != null)
// Reset searching state based on sender
if (sender == MusicLibraryViewModel && MusicLibraryViewModel != null)
{
MusicLibraryViewModel.IsYouTubeSearching = false;
}
else if (sender == YouTubeSearchViewModel && YouTubeSearchViewModel != null)
{
YouTubeSearchViewModel.IsSearching = false;
}
Expand Down
Loading