feat: cascade kill active TriggerRuns on pipeline delete#1110
Open
ishtoo1 wants to merge 1 commit intofeat/cascade-delete-wire-managersfrom
Open
feat: cascade kill active TriggerRuns on pipeline delete#1110ishtoo1 wants to merge 1 commit intofeat/cascade-delete-wire-managersfrom
ishtoo1 wants to merge 1 commit intofeat/cascade-delete-wire-managersfrom
Conversation
|
|
1 task
Go Coverage Report (Bazel)Total Coverage: 63.2% Coverage Policy:
|
ishtoo1
force-pushed
the
feat/cascade-delete-wire-managers
branch
from
72fc393 to
1b5ed29
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-kill-trs
branch
from
5e0bf31 to
28a170c
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-wire-managers
branch
from
1b5ed29 to
c52415a
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-kill-trs
branch
from
28a170c to
97085c9
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-wire-managers
branch
from
c52415a to
725de61
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-kill-trs
branch
from
97085c9 to
851521f
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-wire-managers
branch
from
725de61 to
c92d26d
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-kill-trs
branch
from
851521f to
2cbba97
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-wire-managers
branch
from
c92d26d to
2cd0884
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-kill-trs
branch
from
2cbba97 to
9e54a13
Compare
Summary: Intent: - Kill active TriggerRuns before deleting them during pipeline cascade delete Changes: - Add kill-active-TriggerRuns step in handleDeletion: lists active TRs, sets KILL action on each (best-effort), requeues - Add TestCascadeDelete_ActiveTriggerRuns verifying KILL action set on running TR and requeue Test Plan: - go test ./components/pipeline/... -v -count=1 (all tests pass) Revert Plan: Revert this PR via git revert. Jira Issues:
ishtoo1
force-pushed
the
feat/cascade-delete-wire-managers
branch
from
2cd0884 to
fec99fa
Compare
ishtoo1
force-pushed
the
feat/cascade-delete-kill-trs
branch
from
9e54a13 to
59f65d6
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
What changed?
handleDeletion, after listing children and before the terminal-delete step, list active TRs and issueKillTriggerRunon each (best-effort).TestCascadeDelete_ActiveTriggerRuns.Why?
Addressing #1091.
The correct cascade order is
kill → wait → delete. This PR handles the kill step for TriggerRuns.How did you test it?
bazel test //go/components/pipeline/...— all tests pass.End-to-end behavior of the full cascade-delete stack is verified on a sandbox cluster; results are attached on docs: document pipeline cascade delete behavior #1114.
Potential risks
Release notes
N/A (cumulative user-visible change lands in
feat/cascade-delete-children).Documentation Changes
N/A.
Stacked on top of #1109.