Skip to content

Fix API sync agent workflow after DynamicData rename #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix API sync agent workflow after DynamicData rename #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8602974
Initial plan
Copilot Jun 15, 2026
dd39a4f
fix: tighten api sync agent workflow scope
Copilot Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/api-sync-check.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions .github/workflows/api-sync-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ safe-outputs:
reviewers: [copilot]
allowed-files:
- "R3Ext/**/*.cs"
- "R3.DynamicData/**/*.cs"
- "R3Ext.DynamicData/**/*.cs"
- "R3Ext.Bindings.SourceGenerator/**/*.cs"
- "R3Ext.Bindings.MauiTargets/**/*.cs"
- "docs/**/*.md"
Expand All @@ -44,7 +44,7 @@ Keep R3Ext aligned with the latest ReactiveUI and DynamicData APIs and features.

- **R3Ext repo (this repo)** — a reactive MVVM + dynamic-data library built on R3.
- `R3Ext/` — ReactiveUI-compatible APIs: commands, interactions, bindings, MVVM helpers.
- `R3.DynamicData/` — DynamicData port: observable caches, lists, operators, change sets.
- `R3Ext.DynamicData/` — DynamicData port: observable caches, lists, operators, change sets.
- **ReactiveUI upstream**: `https://github.com/reactiveui/reactiveui`
- **DynamicData upstream**: `https://github.com/reactivemarbles/DynamicData`

Expand All @@ -64,14 +64,18 @@ For **DynamicData** (`reactivemarbles/DynamicData`):
- Fetch the latest release tag and release notes.
- List recently modified public C# files to spot new or changed public APIs.

Before reading local source files, decide whether the upstream changes actually affect public APIs. If both upstream repos show no relevant public API changes in the last 7 days, call `noop` immediately with a short explanation.

### 2 — Inspect the current R3Ext implementation

Read relevant files in this repo to understand the current state:
- `R3Ext/Commands/` — RxCommand implementations.
- `R3Ext/Interactions/` — RxInteraction implementations.
- `R3Ext/Bindings/` — binding helpers and source-generator hooks.
- `R3Ext/Extensions/` — observable extension methods.
- `R3.DynamicData/` — DynamicData port.
- `R3Ext.DynamicData/` — DynamicData port.

Only inspect files that correspond to the candidate upstream API changes. Use targeted searches and small snippets instead of reading entire large files unless a specific candidate change clearly requires it.

### 3 — Identify gaps

Expand Down