Feature/foundation work#3
Merged
Merged
Conversation
- molecules: page-navigation - organisms: site_footer, site_header, site_main - symbiosis: page
- coded brand items to standard size - structured & coded layout for the header & navigation
- reworked grid layout
- completed header layout - some work on main & footer layout
- started work on forms / webforms
- made form use css grid
- added `Roles Classes` to README - expanded requirements - reworked spacing for brand - added basic styling to forms
- coded dimensions for navigation breakpoints
There was a problem hiding this comment.
Pull request overview
This PR lays groundwork for the theme’s component architecture by expanding Atomic Design imports, restructuring page templates into organism-level includes, and updating the PostCSS pipeline to support custom media queries and CSS nesting.
Changes:
- Add PostCSS support for
@custom-mediabreakpoints and nested CSS, and adjust stylelint config accordingly. - Introduce new molecule/organism Twig templates (menus, navigation, header/main/footer, form elements) and corresponding CSS.
- Refactor design tokens and layout CSS (spacing variables, grid gutters, off-canvas layout, and form styling).
Reviewed changes
Copilot reviewed 40 out of 41 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| source/matter.source.css | Updates import order; expands imports to molecules/organisms; disables defaults import. |
| source/04-symbiosis/page/page.html.twig | Refactors page layout to include header/main/footer organism templates via blocks. |
| source/03-organisms/webform/webform.html.twig | Adds a webform wrapper template including title prefix/suffix. |
| source/03-organisms/site_main/site-main.html.twig | Adds organism template for main content + optional sidebar. |
| source/03-organisms/site_header/site-header.organisms.css | Adds nested CSS for responsive header navigation toggle visibility. |
| source/03-organisms/site_header/site-header.html.twig | Adds header organism with branding/navigation (including a menu toggle). |
| source/03-organisms/site_footer/site-footer.html.twig | Adds footer organism template. |
| source/03-organisms/brand/brand.organisms.css | Adds spacing between brand items via gap token. |
| source/02-molecules/textarea/textarea.html.twig | Adds textarea form element template. |
| source/02-molecules/page_navigation/variants/page-navigation--focus.html.twig | Adds focused navigation variant template. |
| source/02-molecules/page_navigation/page-navigation.molecules.css | Adds CSS for navigation toggle positioning and focus alignment. |
| source/02-molecules/page_navigation/page-navigation.html.twig | Adds base page navigation wrapper template. |
| source/02-molecules/menu/variants/menu--navigation-focus.html.twig | Adds a menu variant intended for “focus” navigation rendering. |
| source/02-molecules/menu/variants/menu--main.html.twig | Adds a main navigation menu variant with additional classes. |
| source/02-molecules/menu/menu.html.twig | Adds base recursive menu rendering macro. |
| source/02-molecules/form-element/variants/form-element--textfield.html.twig | Adds textfield variant extending the base form-element template. |
| source/02-molecules/form-element/variants/form-element--textarea.html.twig | Adds textarea variant extending the base form-element template. |
| source/02-molecules/form-element/form-element.html.twig | Adds base form-element wrapper template with label/description/errors handling. |
| source/02-molecules/brand_item/brand-item.molecules.css | Adds logo sizing styling for brand item. |
| source/00-nucleus/root/variables/spacing.css | Renames/introduces spacing tokens (--space--gap*) and adds section comments. |
| source/00-nucleus/root/variables/sizes.css | Adds --item-height token. |
| source/00-nucleus/root/variables/breakpoints.css | Introduces @custom-media breakpoints. |
| source/00-nucleus/root/variables.root.css | Imports new breakpoints variables file. |
| source/00-nucleus/root/grid/grid-layout.css | Updates gutters, switches to custom-media breakpoints, and refactors grid variables. |
| source/00-nucleus/root/globals/utilities.css | Adjusts .flex utility (removes built-in gap var usage). |
| source/00-nucleus/root/globals/styling.css | Updates color/spacing variables for off-canvas link styling. |
| source/00-nucleus/root/globals/reset.css | Adds list margin/padding rules for lists (and updates reset output). |
| source/00-nucleus/root/globals/layout.css | Refactors off-canvas header/main/footer layout and adds permission-navigation overrides. |
| source/00-nucleus/root/globals/forms.old.css | Adds an “old” forms stylesheet (currently present under source/ for linting). |
| source/00-nucleus/root/globals/forms.css | Refactors form styling under .off-canvas and adds .form-item layout rules. |
| source/00-nucleus/root/globals/forms.alt.css | Adds an alternate .form-field styling approach. |
| source/00-nucleus/root/globals.root.css | Enables globals forms stylesheet import. |
| source/00-nucleus/defaults.nucleus.css | Updates spacing var usages to new token names. |
| package.json | Adds postcss-custom-media and postcss-nested. |
| matter.info.yml | Adds body_roles_classes module dependency. |
| gulpfile.js | Adds PostCSS custom media + nesting plugins to the build pipeline. |
| assets/css/matter.theme.css.map | Updates generated sourcemap to reflect new sources and processing. |
| assets/css/matter.theme.css | Updates generated compiled CSS output. |
| README.md | Expands requirements documentation and adds development tooling requirements. |
| .stylelintrc.json | Allows @custom-media and relaxes invalid media query checks for custom media usage. |
| .stylelintignore | Ignores generated assets and common local/dev directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Remove conflicting role="button" from checkbox input (native checkbox semantics should not be overridden with role="button") - Add aria-label="Toggle navigation" to the label element so screen readers announce the toggle's purpose - Add aria-controls="page-navigation--menu" on the checkbox to associate it with the navigation it controls - Wrap navigation includes in a div with matching id for aria-controls Agent-Logs-Url: https://github.com/michaelpadiernos/matter/sessions/44305b56-d070-44e2-a6ff-7e1c1cb657c5 Co-authored-by: mikepadiernos <54547073+mikepadiernos@users.noreply.github.com>
Copilot stopped work on behalf of
mikepadiernos due to an error
May 1, 2026 23:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.