feat(oidc): Add role based access control#11
Open
jacknbeans wants to merge 3 commits into
Open
Conversation
A claim can be used to acquire roles for the user. These roles are then verified with the authorizing role to grant access.
I had originally merged the develop branch of seerr-team/seerr in and I had required these changes at that time. These are no longer required.
…hooks/useToasts' The original feat/oidc-login-v3 branch does not include the changes made to use the new hook for toasts
Author
|
I still need to pull out the translation keys. |
jacknbeans
commented
Jun 22, 2026
| secure: req.protocol === 'https', | ||
| }); | ||
| } | ||
| // if (!config.serverMetadata().supportsPKCE()) { |
Author
There was a problem hiding this comment.
I am not sure why the state generation is commented out if PKCE is supported. My Authelia server throws an error without the state parameter and I believe it breaks the security layers. Since PKCE and state solve different issues, unless I am mistaken in my understanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using a specific claim, access control groups can be acquired from the Authorization Server.
How Has This Been Tested?
Tested with Authelia.
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extract