Skip to content

Feat/OIDC login#1

Open
dominicrico wants to merge 8 commits into
michaelhthomas:feat/oidc-loginfrom
dominicrico:feat/oidc-login
Open

Feat/OIDC login#1
dominicrico wants to merge 8 commits into
michaelhthomas:feat/oidc-loginfrom
dominicrico:feat/oidc-login

Conversation

@dominicrico

Copy link
Copy Markdown

Description

Prevents the slug overriding from the special slug field. This got overridden with the provider name. Added validation to the slug field itself to fail if whitespaces are in the slug.

Also adds an redirect to the oidc provider login if only one provider is configured and no other login option is given.

Screenshot (if UI-related)

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

@michaelhthomas

Copy link
Copy Markdown
Owner

Hi @dominicrico, thanks for your contribution! It looks like you've removed the auto-completion of the slug field (the custom SlugField component implements this), which is desired behavior. The issue at present is that the field should only auto-complete during the initial provider creation (and should be possible to customize at that time).

I'm realizing now that the best approach would be to just set the "placeholder" property on the slug field to the auto-generated one, and use that as a default value during the form submission if no other value is provided. This would also eliminate the need for a custom SlugField component. If you could implement that approach in addition to your changes (and remove the SlugField component), that would be greatly appreciated!

@michaelhthomas
michaelhthomas force-pushed the feat/oidc-login branch 4 times, most recently from fa9adf0 to 39b6f47 Compare July 6, 2025 00:51
@michaelhthomas
michaelhthomas force-pushed the feat/oidc-login branch 2 times, most recently from ff1c1f2 to 7f39794 Compare September 8, 2025 18:08
@github-actions

Copy link
Copy Markdown

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants