fix: sync pact-protocols.md with v3.5.0 and tighten imPACT/wrap-up#2
Merged
Conversation
Update 3 stale sections to match their source-of-truth files: - imPACT: "Two questions, Three outcomes" → "Three questions, Five outcomes" - Algedonic: add broadcast HALT for parallel agents - Stall Detection: already in sync, no changes needed Closes part of Synaptic-Labs-AI#206
- imPACT.md: condense "When to terminate" from 12 lines to 1 paragraph - wrap-up.md: remove belt-and-suspenders note about session_end.py Closes Synaptic-Labs-AI#206
|
|
- Change "Five outcomes" to "Six outcomes" with Escalate to user row - Add TaskUpdate step to Terminate agent Action column - Remove trailing prose (now covered by table row)
Replace old outcome names (Redo solo, Redo with help, Proceed with help, Resume, Terminate) with authoritative v3.5.0 names from imPACT.md. Add 6th outcome (Escalate to user). Remove stale Resume paragraph.
Add v3.5.0 termination signal patterns (redo prior phase, augment present phase, invoke rePACT, etc.) to patterns.py. Add corresponding prose templates to shared_constants.py. Keep old v3.4 patterns for backwards compatibility. Update tests to cover both old and new names.
Overwrite pact-workflows.md with verbatim SSOT content from pact-protocols.md. Update line ranges in verify-protocol-extracts.sh to match current pact-protocols.md structure. All 16 extract checks now pass.
Remove find_active_plans() from session startup. Plan detection is already performed by orchestrate.md when it runs, making the eager scan during SessionStart redundant. Reduces session startup latency by ~100-500ms depending on docs/plans/ directory size.
Enable start-of-line matching for v3.5.0 anchored patterns. Add negative test cases for all 6 v3.5.0 outcome names to verify casual mentions in triage discussion don't trigger false matches.
Protocol sync, Python hook drift fixes, verification script update, and session_init performance optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pact-protocols.mdwith standalone protocol files (imPACT outcomes, algedonic broadcast HALT, stall detection)imPACT.mdandwrap-up.mdfrom PR feat: SDK optimization — lifecycle, stall detection, communication, performance Synaptic-Labs-AI/PACT-Plugin#187Test plan
Closes Synaptic-Labs-AI#206