refactor(commands): extract shared extractFlag helper#133
Merged
Conversation
Move the duplicated extractFlag helper from docs.ts, slides.ts, and sheets.ts into src/utils/args.ts. The three local definitions were identical and have been removed in favor of a single import. Closes #119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dedupes the identical
extractFlaghelper acrossdocs.ts,slides.ts, andsheets.ts. Moves it tosrc/utils/args.tsalongsideparseAccountandnormalizeArgs.Closes #119.
What changed
src/utils/args.ts: AddedextractFlag(args, flag).src/commands/{docs,slides,sheets}.ts: Removed localextractFlagdefinitions; import fromsrc/utils/args.ts.Why
Three identical copies of a six-line helper. Mentioned during code review of #111/#112. Consolidating in
args.tskeeps argument-parsing primitives together.Testing
bun test --concurrent→ 277/277 passbunx tsc --noEmit→ cleanbun run lint→ cleanRisk / Rollout
Zero. The helper body is byte-identical to the three deleted copies;
normalizeArgsat the CLI entry already handles--flag=valuebefore this helper is called.