Display Rails 8 rate limiting info in traces#4
Open
mgodwin wants to merge 3 commits into
Open
Conversation
Display rate_limit.action_controller events in the overview tab when requests are rate limited. Shows rate limit name, request count vs allowed limit, time window, and the identifier used for rate limiting. Also adds a quick indicator in the side panel summary for at-a-glance visibility of rate limited requests.
The rate_limit.action_controller event only fires when a request is actually rejected with a 429 response. Updated the UI text to make this clear - the request was blocked, not just rate limited.
- Add rate_limited scenario action with a limit of 1 request per minute - Add test verifying rate limiting section is displayed when blocked - Add test verifying rate limiting section is not shown for normal requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.