Skip to content
This repository was archived by the owner on Jan 12, 2020. It is now read-only.

created (failing) integration test checking consistency of 3 instances#53

Merged
mgodave merged 2 commits into
mgodave:masterfrom
foldlabs:more-testing
Jan 30, 2014
Merged

created (failing) integration test checking consistency of 3 instances#53
mgodave merged 2 commits into
mgodave:masterfrom
foldlabs:more-testing

Conversation

@abailly

@abailly abailly commented Jan 30, 2014

Copy link
Copy Markdown
Collaborator
  • we start 3 services on ports 10001,10002, and 10003 each managing a
    simple counter
  • we wait for leader to settle then loop commiting a single byte message
  • we expect all instances to have same value for counter

Test is very simple and crude and I did not investigate (yet) why this test is failing...

Test is very simple and crude...
* we start 3 services on ports 10001,10002, and 10003 each managing a
 simple counter
* we wait for leader to settle then loop commiting a single byte message
* we expect all instances to have same value for counter
@abailly

abailly commented Jan 30, 2014

Copy link
Copy Markdown
Collaborator Author

Oddly enough, test is failing because of an off-by-one error in my current proto rpc segregation branch but does not loop forever. I am puzzled...

@abailly

abailly commented Jan 30, 2014

Copy link
Copy Markdown
Collaborator Author

Build is failing because I used Java 7 features hence running on jdk 6 will fail. Will update the change to fall back on pure Java 6.

@justinsb

Copy link
Copy Markdown
Collaborator

Looks good to me. I think we'll need integration tests for testing cluster reconfiguration ( #54), so this is great timing!

Adds new dependency on AssertJ, but that looks like a nice library, and is only referenced in test mode.

@mgodave

mgodave commented Jan 30, 2014

Copy link
Copy Markdown
Owner

@justinsb meet @abailly, @abailly meet @justinsb.

mgodave added a commit that referenced this pull request Jan 30, 2014
created (failing) integration test checking consistency of 3 instances
@mgodave mgodave merged commit 39a690c into mgodave:master Jan 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants