Skip to content

[mobt-1157] Fix decision tree returning more than one threshold#2375

Open
jdjonathandavies wants to merge 2 commits into
metoppv:masterfrom
jdjonathandavies:jonathan.davies_first_test_branch
Open

[mobt-1157] Fix decision tree returning more than one threshold#2375
jdjonathandavies wants to merge 2 commits into
metoppv:masterfrom
jdjonathandavies:jonathan.davies_first_test_branch

Conversation

@jdjonathandavies
Copy link
Copy Markdown
Contributor

@jdjonathandavies jdjonathandavies commented May 6, 2026

Description

Part of work on weather symbol decision tree in motb-1157

When adding decision tree nodes using screen temperature the decision tree would raise an exception. After debugging this issue I identified the cause being too loose a tolerance when selecting thresholds.

Solution

  • Loosen the threshold tolerance from 0.01 to 0.001
  • Add some comments around the steps creating the iris.Constraint used to extract the threshold
  • Add an additional check on the extracted threshold cube to ensure that only a single threshold is extracted
  • raise a ValueError with an informative message if there are more than 1 threshold extracted

@jdjonathandavies jdjonathandavies changed the title [motb-1157] Fix decision tree returning more than one threshold [mobt-1157] Fix decision tree returning more than one threshold May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants