Flow integration#59
Open
DanielDornhardt wants to merge 8 commits into
Open
Conversation
…Router in ionHeaderBar.
…ttribute to the ionNavView - directive.
…g, but leaving it in to maybe work on later. Conflicts: components/ionHeaderBar/ionHeaderBar.html package.js
…egration-2 Conflicts: components/ionContent/ionContent.html components/ionContent/ionContent.js components/ionHeaderBar/ionHeaderBar.html components/ionInfiniteScroll/ionInfiniteScroll.js components/ionItem/ionItem.js components/ionList/ionList.js components/ionScroll/ionScroll.js lib/controller/infiniteScrollController.js lib/controller/listController.js lib/controller/scrollController.js lib/controller/sideMenuController.js lib/meteoric.js lib/utils/tap.js lib/views/listView.js lib/views/slidesView.js package.js styles/main.scss vendor/slick.js vendor/slip.js
Member
|
I'll read this code along with ionic's $ionicHistory, so well have an idea how they will fit to each other, if they can fit at all. Anyway, I'll get back to you immediately when I've done that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a tacit pull request, actually more a request for attention... I keep tracking your branch and merging it into my branch. I'm using this version in two projects now and so far it seems it's working pretty well.
There are some workarounds in eg. how I use a different way to load info into my header bar (actually I just noticed I should put the same stuff in for the footer bar), and I think there are some rough edges about the iron-router version as well, but seeing as in many cases it's almost as good to use the ionic HTML as to use the directives, this is probably a "good enough" place to start to plan further integration of the Iron- and the Flow-Router - Branches.
If you'd have some time maybe we could chat a bit on how to join this in somehow to enable flow-router - users to use meteoric. I think it'd be great for the project (many people have switched to flow-router or want to start new projects using flow-router I think).
Maybe another way (eg. using additional, selectable packages for either iron- or flow-router) would be possible as well. I'd love getting this into your branch, especially as you seem to be doing great work structuring and enhancing this project.
Let me know, if you're interested I'll drop you a mail or you can send me one, it's my firstname at mylastname . com and maybe we can have a short chat or something.