INT-578 Use PVC by default for all DB branching - #307
Open
vladrbg wants to merge 1 commit into
Open
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| docs/sharing-the-cluster/db-branching.md | Adds the new PVC storage guidance, but its no-change upgrade claim conflicts with the documented scope of legacy volume-limit settings. |
Prompt To Fix All With AI
### Issue 1
docs/sharing-the-cluster/db-branching.md:153
**Legacy volume limits stop applying**
When upgrading with explicit `initPodVolumeLimit` or `databasePodVolumeLimit` values but no `emptyDir` opt-out, the new default PVC path stops consuming those settings and instead uses the 20Gi PVC defaults, causing branches configured for larger databases to run out of volume space despite the claim that every explicit setting keeps its meaning.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "pvc" | Re-trigger Greptile
|
|
||
| ### Before and after 3.191.0 | ||
|
|
||
| Up to operator `3.190.0`, branches always ran on node-local `emptyDir` volumes. Since `3.191.0`, per-branch PVCs are the default; no config change is needed on upgrade, and every explicit setting keeps its meaning: |
Contributor
There was a problem hiding this comment.
Legacy volume limits stop applying
When upgrading with explicit initPodVolumeLimit or databasePodVolumeLimit values but no emptyDir opt-out, the new default PVC path stops consuming those settings and instead uses the 20Gi PVC defaults, causing branches configured for larger databases to run out of volume space despite the claim that every explicit setting keeps its meaning.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/sharing-the-cluster/db-branching.md
Line: 153
Comment:
**Legacy volume limits stop applying**
When upgrading with explicit `initPodVolumeLimit` or `databasePodVolumeLimit` values but no `emptyDir` opt-out, the new default PVC path stops consuming those settings and instead uses the 20Gi PVC defaults, causing branches configured for larger databases to run out of volume space despite the claim that every explicit setting keeps its meaning.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.