Skip to content

INT-578 Use PVC by default for all DB branching - #307

Open
vladrbg wants to merge 1 commit into
mainfrom
vladr/int-578
Open

INT-578 Use PVC by default for all DB branching#307
vladrbg wants to merge 1 commit into
mainfrom
vladr/int-578

Conversation

@vladrbg

@vladrbg vladrbg commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@linear-code

linear-code Bot commented Aug 7, 2026

Copy link
Copy Markdown

INT-578

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR documents PVC-backed storage as the default for database branches beginning with operator 3.191.0, motivated by reducing reliance on node-local capacity.

  • Explains the release-boundary changes to storage and memory defaults.
  • Adds Helm examples for PVC sizing, StorageClass selection, and emptyDir opt-out.
  • Documents fallback and explicit-volume precedence behavior.

Important Files Changed

Filename Overview
docs/sharing-the-cluster/db-branching.md Adds the new PVC storage guidance, but its no-change upgrade claim conflicts with the documented scope of legacy volume-limit settings.

Fix All in Cursor Fix All in Codex Fix All in Claude Code

Prompt To Fix All With AI
### Issue 1
docs/sharing-the-cluster/db-branching.md:153
**Legacy volume limits stop applying**

When upgrading with explicit `initPodVolumeLimit` or `databasePodVolumeLimit` values but no `emptyDir` opt-out, the new default PVC path stops consuming those settings and instead uses the 20Gi PVC defaults, causing branches configured for larger databases to run out of volume space despite the claim that every explicit setting keeps its meaning.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "pvc" | Re-trigger Greptile


### Before and after 3.191.0

Up to operator `3.190.0`, branches always ran on node-local `emptyDir` volumes. Since `3.191.0`, per-branch PVCs are the default; no config change is needed on upgrade, and every explicit setting keeps its meaning:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Legacy volume limits stop applying

When upgrading with explicit initPodVolumeLimit or databasePodVolumeLimit values but no emptyDir opt-out, the new default PVC path stops consuming those settings and instead uses the 20Gi PVC defaults, causing branches configured for larger databases to run out of volume space despite the claim that every explicit setting keeps its meaning.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/sharing-the-cluster/db-branching.md
Line: 153

Comment:
**Legacy volume limits stop applying**

When upgrading with explicit `initPodVolumeLimit` or `databasePodVolumeLimit` values but no `emptyDir` opt-out, the new default PVC path stops consuming those settings and instead uses the 20Gi PVC defaults, causing branches configured for larger databases to run out of volume space despite the claim that every explicit setting keeps its meaning.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Cursor Fix in Codex Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant