Refactor/structs replace jsonvalue#18
Draft
yellowHatpro wants to merge 4 commits into
Draft
Conversation
yellowHatpro
commented
Nov 18, 2024
yellowHatpro
commented
Collaborator
- Replaced JsonValue with structs
Collaborator
|
You may want to remove some of those options. For fields that aren't optional you can just put the type and not have to worry about it being an option ;) (Although you need to be sure they aren't optional, which isn't always clear cough musicbrainz API) |
Collaborator
Author
|
@RustyNova016 haha, thanks for the suggestion. Sorry I was inactive last week, so couldn't do much. I was doubtful about the types, so I ended up making them all optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.