add event-driven auth recovery for WebSockets behind proxies#1391
Merged
Conversation
richard-to
reviewed
May 5, 2026
| this.experimentService.authProxyEnabled | ||
| ) { | ||
| console.debug('Window focused, probing connection...'); | ||
| const isRedirected = await this.probeConnection(); |
Collaborator
There was a problem hiding this comment.
Is there any race condition that's possible here? Mainly trying to think what would happen if multiple probe connections were triggered.
Contributor
Author
There was a problem hiding this comment.
added isProbing flag to prevent concurrent async operations in TypeScript
Collaborator
|
I'll take another look in a couple days. Busy this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in, event-driven solution to allow applications to handle this gracefully without forcing a destructive full-page reload that loses user state.
redirect: 'manual'.mesop:auth-requiredCustomEvent on thewindowobject, passing the target URL in the details.focusevent on thewindow. When the user returns to the tab (presumably after completing the authentication flow in another window or tab), it probes again and automatically reconnects if successful.fixes #1389