Skip to content

Remove UA_868#5

Open
sashko wants to merge 1 commit into
meshtastic:mainfrom
sashko:main
Open

Remove UA_868#5
sashko wants to merge 1 commit into
meshtastic:mainfrom
sashko:main

Conversation

@sashko

@sashko sashko commented Jul 18, 2026

Copy link
Copy Markdown

UA_868 has been removed as obsolete.

Summary by CodeRabbit

  • Bug Fixes
    • Removed the obsolete UA_868 option from the Region dropdown.
    • Updated region conversion so UA_868 is no longer mapped to a numeric region code.
    • Numeric inputs that previously resolved to the removed 15 mapping now no longer produce a region code (treated as invalid).

@CLAassistant

CLAassistant commented Jul 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bf342d18-a0d8-44cf-ae60-4b46a1418414

📥 Commits

Reviewing files that changed from the base of the PR and between b0cd92d and 0a28a1d.

📒 Files selected for processing (2)
  • web/fs-setup.js
  • web/index.html
💤 Files with no reviewable changes (1)
  • web/index.html

📝 Walkthrough

Walkthrough

The UA_868 region was removed from the numeric region mapping, conversion logic, and web interface’s Region dropdown.

Changes

Region selection

Layer / File(s) Summary
Remove UA_868 mapping and option
web/fs-setup.js, web/index.html
Removes UA_868 from REGION_CODES, makes numeric code 15 return null, and removes the UA_868 Region dropdown option.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: thebentern

Poem

A rabbit hops through regions bright,
UA_868 fades from sight.
The map and dropdown now agree,
With tidy paths for you and me.
Nibble, click, success! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely matches the main change: removing UA_868 from the configuration and UI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/fs-setup.js`:
- Line 43: Update regionToCode in web/fs-setup.js to reject numeric code 15 as
well as the removed UA_868 alias, preventing MESH_REGION=15 from reaching
wasm_set_region while preserving valid numeric passthrough for other region
codes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 967f3540-1fd0-4bff-aa19-9063a2c01dc6

📥 Commits

Reviewing files that changed from the base of the PR and between c7c3c46 and b0cd92d.

📒 Files selected for processing (2)
  • web/fs-setup.js
  • web/index.html
💤 Files with no reviewable changes (1)
  • web/index.html

Comment thread web/fs-setup.js
UA_868 has been removed as obsolete.

* meshtastic/firmware#10994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants