Remove UA_868#5
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe ChangesRegion selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/fs-setup.js`:
- Line 43: Update regionToCode in web/fs-setup.js to reject numeric code 15 as
well as the removed UA_868 alias, preventing MESH_REGION=15 from reaching
wasm_set_region while preserving valid numeric passthrough for other region
codes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 967f3540-1fd0-4bff-aa19-9063a2c01dc6
📒 Files selected for processing (2)
web/fs-setup.jsweb/index.html
💤 Files with no reviewable changes (1)
- web/index.html
UA_868 has been removed as obsolete. * meshtastic/firmware#10994
UA_868 has been removed as obsolete.
Summary by CodeRabbit
UA_868option from the Region dropdown.UA_868is no longer mapped to a numeric region code.15mapping now no longer produce a region code (treated as invalid).