Skip to content

Fixed pin state setup when SX126X_ANT_SW is defined #10947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexandrZloy wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixed pin state setup when SX126X_ANT_SW is defined #10947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bfe7a8
Fixed pin state setup when SX126X_ANT_SW is defined
AlexandrZloy Jul 8, 2026
c7489cc
Fix portduino_config.lora_sx126x_ant_sw_pin.pin case
AlexandrZloy Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mesh/SX126xInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ template <typename T> bool SX126xInterface<T>::init()
// means this workaround is not necessary.
#ifdef SX126X_ANT_SW // Perhaps add RADIOLIB_NC check, and beforehand define as such if it is undefined, but it is not commonly
// used and not part of the 'default' set of pin definitions.
digitalWrite(SX126X_ANT_SW, HIGH);
pinMode(SX126X_ANT_SW, OUTPUT);
digitalWrite(SX126X_ANT_SW, HIGH);
#endif

#ifdef SX126X_POWER_EN // Perhaps add RADIOLIB_NC check, and beforehand define as such if it is undefined, but it is not commonly
Expand All @@ -72,8 +72,8 @@ template <typename T> bool SX126xInterface<T>::init()
#if ARCH_PORTDUINO
tcxoVoltage = (float)portduino_config.dio3_tcxo_voltage / 1000;
if (portduino_config.lora_sx126x_ant_sw_pin.pin != RADIOLIB_NC) {
digitalWrite(portduino_config.lora_sx126x_ant_sw_pin.pin, HIGH);
pinMode(portduino_config.lora_sx126x_ant_sw_pin.pin, OUTPUT);
digitalWrite(portduino_config.lora_sx126x_ant_sw_pin.pin, HIGH);
}
#endif
if (tcxoVoltage == 0.0)
Expand Down Expand Up @@ -548,4 +548,4 @@ template <typename T> void SX126xInterface<T>::setTransmitEnable(bool txon)
#endif
}

#endif
#endif
Loading