Skip to content

fix(position-config): stop writing deprecated gpsEnabled on save (#2024) #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garthvh merged 2 commits into from
Jul 20, 2026
Merged

fix(position-config): stop writing deprecated gpsEnabled on save (#2024) #2110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
127388e
fix(position-config): stop writing deprecated gpsEnabled on save (#2024)
bruschill Jul 18, 2026
f4bce47
docs(position-config): document GPS mode source-of-truth migration
bruschill Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Meshtastic/Resources/docs/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,8 @@
"app",
"radio",
"node",
"device",
"firmware",
"device",
"from",
"region",
"position",
Expand All @@ -421,12 +421,12 @@
"connected",
"configure",
"unknown",
"setting",
"preset",
"pages",
"packets",
"module"
"packets"
],
"charCount": 8930
"charCount": 9302
},
{
"id": "signal-meter",
Expand Down
2 changes: 2 additions & 0 deletions Meshtastic/Resources/docs/markdown/user/settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ Wi-Fi SSID/password for TCP connection, NTP server, and Ethernet (supported hard

GPS update interval, position precision, and smart position broadcasting. Enable **Broadcast Position** to share your location with the mesh.

The **GPS Mode** selector (Enabled / Disabled / Not Present) is the single source of truth for the GPS state that the app writes to the radio. The older on/off `gpsEnabled` field it replaced is deprecated: the app no longer writes it, but still reads it from older firmware so existing devices keep working. No action is needed when upgrading — your GPS setting is preserved.

### Power

Battery saving profiles, sleep modes, and minimum wake time. Critical for solar-powered router nodes.
Expand Down
1 change: 1 addition & 0 deletions Meshtastic/Resources/docs/user/settings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ <h3>Network</h3>
<p>Wi-Fi SSID/password for TCP connection, NTP server, and Ethernet (supported hardware only).</p>
<h3>Position</h3>
<p>GPS update interval, position precision, and smart position broadcasting. Enable <strong>Broadcast Position</strong> to share your location with the mesh.</p>
<p>The <strong>GPS Mode</strong> selector (Enabled / Disabled / Not Present) is the single source of truth for the GPS state that the app writes to the radio. The older on/off <code>gpsEnabled</code> field it replaced is deprecated: the app no longer writes it, but still reads it from older firmware so existing devices keep working. No action is needed when upgrading — your GPS setting is preserved.</p>
<h3>Power</h3>
<p>Battery saving profiles, sleep modes, and minimum wake time. Critical for solar-powered router nodes.</p>
<h2>Module Configuration</h2>
Expand Down
4 changes: 3 additions & 1 deletion Meshtastic/Views/Settings/Config/PositionConfig.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,9 @@ struct PositionConfig: View {
) { fromUser, toUser in
var pc = Config.PositionConfig()
pc.positionBroadcastSmartEnabled = smartPositionEnabled
pc.gpsEnabled = gpsMode == 1
// gpsMode is the source of truth; the deprecated gpsEnabled field is
// intentionally not written (removed upstream, see issue #2024). Older
// firmware sending gpsEnabled is still tolerated on read (setPositionValues).
pc.gpsMode = Config.PositionConfig.GpsMode(rawValue: gpsMode) ?? Config.PositionConfig.GpsMode.notPresent
Comment thread
coderabbitai[bot] marked this conversation as resolved.
pc.fixedPosition = fixedPosition
pc.gpsUpdateInterval = UInt32(gpsUpdateInterval)
Expand Down
2 changes: 2 additions & 0 deletions docs/user/settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ Wi-Fi SSID/password for TCP connection, NTP server, and Ethernet (supported hard

GPS update interval, position precision, and smart position broadcasting. Enable **Broadcast Position** to share your location with the mesh.

The **GPS Mode** selector (Enabled / Disabled / Not Present) is the single source of truth for the GPS state that the app writes to the radio. The older on/off `gpsEnabled` field it replaced is deprecated: the app no longer writes it, but still reads it from older firmware so existing devices keep working. No action is needed when upgrading — your GPS setting is preserved.

### Power

Battery saving profiles, sleep modes, and minimum wake time. Critical for solar-powered router nodes.
Expand Down